Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1330613005: PPC: [es6] Initial steps towards a correct implementation of IsCallable. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Initial steps towards a correct implementation of IsCallable. Port 8a378f46d52ce64578c71313ed76a67592fbf63c Original commit message: This turns the has_instance_call_handler bit on Map into an is_callable bit, that matches the spec definition of IsCallable (i.e. instances have [[Call]] internal methods). Also fix the typeof operator to properly say "function" for everything that is callable. Also remove the (unused) premature %_GetPrototype optimization from Crankshaft, which just complicated the Map bit swap. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/6990fb1c19f6bd14895475d5081fccfc9ccfe750 Cr-Commit-Position: refs/heads/master@{#30576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -42 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +12 lines, -11 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-09-03 16:25:24 UTC) #1
dstence
lgtm
5 years, 3 months ago (2015-09-03 18:14:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330613005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330613005/1
5 years, 3 months ago (2015-09-03 18:17:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 18:44:45 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 18:44:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6990fb1c19f6bd14895475d5081fccfc9ccfe750
Cr-Commit-Position: refs/heads/master@{#30576}

Powered by Google App Engine
This is Rietveld 408576698