Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1330573003: Add Layout Test to check that color property works with all:{unset/inherit} (Closed)

Created:
5 years, 3 months ago by nainar
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add Layout Test to check that color property works with all:{unset/inherit} This patch adds a layout test to ensure that the 'color' property works as expected when used with `all:unset` or `all:inherit`. BUG=420781 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201881

Patch Set 1 #

Patch Set 2 : Post edit #

Patch Set 3 : Color/style changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
A LayoutTests/fast/css/all-inherit-or-unset-color.html View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/all-inherit-or-unset-color-expected.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
nainar1
Hi, Please take a look? Thanks!
5 years, 3 months ago (2015-09-04 07:17:54 UTC) #2
Timothy Loh
On 2015/09/04 07:17:54, nainar wrote: > Hi, > > Please take a look? > > ...
5 years, 3 months ago (2015-09-07 01:30:05 UTC) #3
nainar1
Could you please take a look now?
5 years, 3 months ago (2015-09-07 07:15:10 UTC) #4
Timothy Loh
On 2015/09/07 07:15:10, nainar wrote: > Could you please take a look now? Usually red ...
5 years, 3 months ago (2015-09-07 07:55:18 UTC) #5
nainar1
Have fixed the issues you asked for. Could you take a look now?
5 years, 3 months ago (2015-09-08 00:04:03 UTC) #6
Timothy Loh
lgtm
5 years, 3 months ago (2015-09-08 00:19:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330573003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330573003/40001
5 years, 3 months ago (2015-09-08 00:20:02 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 00:46:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201881

Powered by Google App Engine
This is Rietveld 408576698