Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1330573002: Rename Caret.{h,cpp} to CaretBase to match class. (Closed)

Created:
5 years, 3 months ago by wkorman
Modified:
5 years, 3 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename Caret.{h,cpp} to CaretBase to match class. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -290 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/editing/Caret.h View 1 chunk +0 lines, -77 lines 0 comments Download
D Source/core/editing/Caret.cpp View 1 chunk +0 lines, -203 lines 0 comments Download
A + Source/core/editing/CaretBase.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/editing/CaretBase.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/DragCaretController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
wkorman
5 years, 3 months ago (2015-09-03 04:17:37 UTC) #2
yosin_UTC9
lgtm Thanks for cleanup! +tkent@ for core.gypi OWNERS
5 years, 3 months ago (2015-09-03 04:38:39 UTC) #4
tkent
lgtm
5 years, 3 months ago (2015-09-03 04:39:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330573002/1
5 years, 3 months ago (2015-09-03 04:39:51 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 05:42:17 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201700

Powered by Google App Engine
This is Rietveld 408576698