Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: ui/base/resource/resource_bundle_win.cc

Issue 133053002: [Cleanup] Don't try to load obsolete touch resources (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/base/resource/resource_bundle_win.h" 5 #include "ui/base/resource/resource_bundle_win.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "ui/base/layout.h" 10 #include "ui/base/layout.h"
(...skipping 20 matching lines...) Expand all
31 31
32 // Return just the name of the pack file. 32 // Return just the name of the pack file.
33 return base::FilePath(base::ASCIIToUTF16(pak_name)); 33 return base::FilePath(base::ASCIIToUTF16(pak_name));
34 } 34 }
35 35
36 } // namespace 36 } // namespace
37 37
38 void ResourceBundle::LoadCommonResources() { 38 void ResourceBundle::LoadCommonResources() {
39 // As a convenience, add the current resource module as a data packs. 39 // As a convenience, add the current resource module as a data packs.
40 data_packs_.push_back(new ResourceDataDLL(GetCurrentResourceDLL())); 40 data_packs_.push_back(new ResourceDataDLL(GetCurrentResourceDLL()));
41 // Have high-DPI resources for 140% and 180% scaling on Windows based on 41 AddDataPackFromPath(
42 // default scaling for Metro mode. If high-DPI mode is enabled, load resource 42 GetResourcesPakFilePath("chrome_100_percent.pak"),
43 // pak closest to the desired scale factor. The high-DPI resources are 43 SCALE_FACTOR_100P);
44 // scaled up from 100% touch.
45 float scale = gfx::win::GetDeviceScaleFactor();
46 bool force_touch_resources = false;
47 switch(ui::GetSupportedScaleFactor(scale)) {
48 case ui::SCALE_FACTOR_180P:
49 AddDataPackFromPath(GetResourcesPakFilePath(
50 "chrome_touch_180_percent.pak"),
51 SCALE_FACTOR_180P);
52 force_touch_resources = true;
53 break;
54 case ui::SCALE_FACTOR_140P:
55 AddDataPackFromPath(GetResourcesPakFilePath(
56 "chrome_touch_140_percent.pak"),
57 SCALE_FACTOR_140P);
58 force_touch_resources = true;
59 }
60 // TODO(kevers|girard): Remove loading of 1x resources when in high-DPI
61 // mode once all resources are available at 140% and 180%.
62 if (ui::GetDisplayLayout() == ui::LAYOUT_TOUCH || force_touch_resources) {
63 AddDataPackFromPath(
64 GetResourcesPakFilePath("chrome_touch_100_percent.pak"),
65 SCALE_FACTOR_100P);
66 } else {
67 AddDataPackFromPath(
68 GetResourcesPakFilePath("chrome_100_percent.pak"),
69 SCALE_FACTOR_100P);
70 }
71 } 44 }
72 45
73 gfx::Image& ResourceBundle::GetNativeImageNamed(int resource_id, ImageRTL rtl) { 46 gfx::Image& ResourceBundle::GetNativeImageNamed(int resource_id, ImageRTL rtl) {
74 // Flipped image is not used on Windows. 47 // Flipped image is not used on Windows.
75 DCHECK_EQ(rtl, RTL_DISABLED); 48 DCHECK_EQ(rtl, RTL_DISABLED);
76 49
77 // Windows only uses SkBitmap for gfx::Image, so this is the same as 50 // Windows only uses SkBitmap for gfx::Image, so this is the same as
78 // GetImageNamed. 51 // GetImageNamed.
79 return GetImageNamed(resource_id); 52 return GetImageNamed(resource_id);
80 } 53 }
81 54
82 void SetResourcesDataDLL(HINSTANCE handle) { 55 void SetResourcesDataDLL(HINSTANCE handle) {
83 resources_data_dll = handle; 56 resources_data_dll = handle;
84 } 57 }
85 58
86 HICON LoadThemeIconFromResourcesDataDLL(int icon_id) { 59 HICON LoadThemeIconFromResourcesDataDLL(int icon_id) {
87 return ::LoadIcon(GetCurrentResourceDLL(), MAKEINTRESOURCE(icon_id)); 60 return ::LoadIcon(GetCurrentResourceDLL(), MAKEINTRESOURCE(icon_id));
88 } 61 }
89 62
90 } // namespace ui; 63 } // namespace ui;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698