Infobar material design refresh: bg color

Infobar material design refresh: bg color

BUG=520266
Committed: https://crrev.com/3ef33286c4da3f97a174beda35ffd2a09649d60c
Cr-Commit-Position: refs/heads/master@{#347067}

[Evan Stade, 2015-09-02 17:52:20]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-09-02 21:46:10]

LGTM

https://codereview.chromium.org/1330513002/diff/1/components/infobars/core/in...
File components/infobars/core/infobar.cc (right):

https://codereview.chromium.org/1330513002/diff/1/components/infobars/core/in...
components/infobars/core/infobar.cc:22: static const SkColor
kPageActionBackgroundColorMd = SK_ColorWHITE;
Nit: Put these in GetTopColor() so they're next to their uses, and so they match
how we already put the other color constants there (but see below also)

https://codereview.chromium.org/1330513002/diff/1/components/infobars/core/in...
components/infobars/core/infobar.cc:49: kWarningBackgroundColorMd :
kPageActionBackgroundColorMd;
Should we be getting these colors from the theme provider or something instead
of hardcoding them here?

[Evan Stade, 2015-09-02 23:34:35]

https://codereview.chromium.org/1330513002/diff/1/components/infobars/core/in...
File components/infobars/core/infobar.cc (right):

https://codereview.chromium.org/1330513002/diff/1/components/infobars/core/in...
components/infobars/core/infobar.cc:22: static const SkColor
kPageActionBackgroundColorMd = SK_ColorWHITE;
On 2015/09/02 21:46:10, Peter Kasting wrote:
> Nit: Put these in GetTopColor() so they're next to their uses, and so they
match
> how we already put the other color constants there (but see below also)

done

https://codereview.chromium.org/1330513002/diff/1/components/infobars/core/in...
components/infobars/core/infobar.cc:49: kWarningBackgroundColorMd :
kPageActionBackgroundColorMd;
On 2015/09/02 21:46:10, Peter Kasting wrote:
> Should we be getting these colors from the theme provider or something instead
> of hardcoding them here?

I don't see any other places where this is used in Chrome code yet, so for now
I'll leave it local to this file.

[Evan Stade, 2015-09-02 23:35:17]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-09-02 23:35:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1330513002/#ps20001
(title: "more localler")

[commit-bot: I haz the power, 2015-09-02 23:35:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1330513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1330513002/20001

[commit-bot: I haz the power, 2015-09-03 00:34:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-03 00:35:07]

Patchset 2 (id:??) landed as
https://crrev.com/3ef33286c4da3f97a174beda35ffd2a09649d60c
Cr-Commit-Position: refs/heads/master@{#347067}