Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1330473002: Specify try_job_retry_config for Skia try jobs (Closed)

Created:
5 years, 3 months ago by rmistry
Modified:
5 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Specify try_job_retry_config for Skia try jobs Retry config support was added to the CQ in https://chromereviews.googleplex.com/240527013/ This CL uses the retry config in Skia's cq.cfg file. CQ's default failure_retry_weight is 1. We set it to 2 which will immediately go beyond the try job quota and will not retry for failures. It will retry for transient errors. BUG=chromium:522460 TBR=mtklein NOTRY=true Committed: https://skia.googlesource.com/skia/+/a3710c32623c23347b7e09e3e9e559dd8429287e

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M infra/branch-config/cq.cfg View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rmistry
5 years, 3 months ago (2015-09-02 12:21:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330473002/1
5 years, 3 months ago (2015-09-02 12:21:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330473002/1
5 years, 3 months ago (2015-09-02 12:22:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a3710c32623c23347b7e09e3e9e559dd8429287e
5 years, 3 months ago (2015-09-02 12:23:28 UTC) #8
mtklein
lgtm
5 years, 3 months ago (2015-09-02 12:54:26 UTC) #9
rmistry
5 years, 3 months ago (2015-09-03 16:30:44 UTC) #10
Message was sent while issue was closed.
On 2015/09/02 12:54:26, mtklein wrote:
> lgtm

FYI: https://code.google.com/p/chromium/issues/detail?id=522460 has been fixed.
Failures should no longer repeat. Let me know if you notice that it does not
behave like that.

Powered by Google App Engine
This is Rietveld 408576698