components/data_use_measurement/core/data_use_user_data.h - Issue 1330443002: Report data usage UMA for Chrome services

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_use_measurement/core/data_use_user_data.h

Issue 1330443002: Report data usage UMA for Chrome services (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewArchServices

Patch Set: Addressing reviewers' comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/data_use_measurement/core/data_use_user_data.h

diff --git a/components/data_use_measurement/core/data_use_user_data.h b/components/data_use_measurement/core/data_use_user_data.h

index 80d310e0ade12ae9a8da8e049d71f752603b701c..d9c99bc7b8de6edb72f171273f70fc158e120dca 100644

--- a/components/data_use_measurement/core/data_use_user_data.h

+++ b/components/data_use_measurement/core/data_use_user_data.h

@@ -23,6 +23,22 @@ class DataUseUserData : public base::SupportsUserData::Data {

enum ServiceType {

NOT_TAGGED,

SUGGESTIONS,

+ TRANSLATE,

+ SYNC,

+ COMPLETE,

sclittle 2015/09/04 23:17:57 nit: It's not clear what service COMPLETE links to

amohammadkhan 2015/09/04 23:28:01 Done.

+ INVALIDATION,

+ RAPPOR,

+ POLICY,

+ UMA,

+ GOOGLE_APIS,

+ DOMAIN_RELIABILITY,

+ PROFILE_DOWNLOADER,

+ GOOGLE_URL_TRACKER,

+ AUTOFILL,

+ VARIATIONS,

+ DEVICE_MANAGEMENT,

+ SPELL_CHECKER,

+ GEO_LOCATION,

};

explicit DataUseUserData(ServiceType service_type);