Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1330443002: Report data usage UMA for Chrome services (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewArchServices
Patch Set: Updating the function name and some of gyp files. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« google_apis/gcm/engine/unregistration_request.cc ('K') | « sync/sync.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index e4030bde6dc326d3c444e3ed84f4e4f7dc7be0c9..6e6762c88a76023022158f2195e2d488870d9ab8 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -55229,7 +55229,23 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<enum name="DataUseServices" type="int">
<int value="0" label="Not Tagged"/>
- <int value="1" label="Suggestions Service"/>
+ <int value="1" label="Suggestions"/>
+ <int value="2" label="Translate"/>
+ <int value="3" label="Sync"/>
+ <int value="4" label="Complete(OmniBox)"/>
+ <int value="5" label="Invalidation"/>
+ <int value="6" label="Rappor"/>
+ <int value="7" label="Policy"/>
+ <int value="8" label="UMA"/>
+ <int value="9" label="Google APIs"/>
+ <int value="10" label="Domain Reliability"/>
+ <int value="11" label="Profile Downloader"/>
+ <int value="12" label="URL Tracker"/>
Ilya Sherman 2015/09/04 22:10:40 nit: "Google URL Tracker"
amohammadkhan 2015/09/04 23:03:16 Done.
+ <int value="13" label="Autofill"/>
+ <int value="14" label="Variations"/>
Ilya Sherman 2015/09/04 22:10:39 nit: It's a little odd to separate UMA, Rappor, an
amohammadkhan 2015/09/04 23:03:16 Yes. By having them separated, the contribution of
Ilya Sherman 2015/09/08 21:45:25 Sorry, I see now that my question wasn't clear. W
amohammadkhan 2015/09/08 23:28:31 Sorry I didn't understand first time what you mean
+ <int value="15" label="Device Management"/>
+ <int value="16" label="Spell Checker"/>
+ <int value="17" label="Geo Location"/>
</enum>
<enum name="DecodedImageType" type="int">
@@ -74786,6 +74802,22 @@ To add a new entry, add it with any value and run test to compute valid value.
<histogram_suffixes name="DataUse.Service.Types" separator=".">
<suffix name="NotTagged"/>
<suffix name="Suggestions"/>
+ <suffix name="Translate"/>
+ <suffix name="Sync"/>
+ <suffix name="Complete"/>
+ <suffix name="Invalidation"/>
+ <suffix name="Rappor"/>
+ <suffix name="Policy"/>
+ <suffix name="UMA"/>
+ <suffix name="GoogleAPIs"/>
+ <suffix name="DomainReliability"/>
+ <suffix name="ProfileDownloader"/>
+ <suffix name="URLTracker"/>
+ <suffix name="Autofill"/>
+ <suffix name="Variations"/>
+ <suffix name="DeviceManagement"/>
+ <suffix name="SpellChecker"/>
+ <suffix name="GeoLocation"/>
<affected-histogram name="DataUse.MessageSize"/>
</histogram_suffixes>
« google_apis/gcm/engine/unregistration_request.cc ('K') | « sync/sync.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698