 Chromium Code Reviews
 Chromium Code Reviews Issue 1330443002:
  Report data usage UMA for Chrome services  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@NewArchServices
    
  
    Issue 1330443002:
  Report data usage UMA for Chrome services  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@NewArchServices| Index: components/data_use_measurement/core/data_use_user_data.cc | 
| diff --git a/components/data_use_measurement/core/data_use_user_data.cc b/components/data_use_measurement/core/data_use_user_data.cc | 
| index c6ad360a9afb488bc6e0a723de7cec8ab9678ff1..d6bda40dff9eb9daa135203c9195f821eb4432a9 100644 | 
| --- a/components/data_use_measurement/core/data_use_user_data.cc | 
| +++ b/components/data_use_measurement/core/data_use_user_data.cc | 
| @@ -31,6 +31,38 @@ const char* DataUseUserData::GetServiceName( | 
| return "Suggestions"; | 
| case NOT_TAGGED: | 
| return "NotTagged"; | 
| + case TRANSLATE: | 
| + return "Translate"; | 
| + case SYNC: | 
| + return "Sync"; | 
| + case COMPLETE: | 
| + return "Complete"; | 
| + case INVALIDATION: | 
| + return "Invalidation"; | 
| + case RAPPOR: | 
| + return "Rappor"; | 
| + case POLICY: | 
| + return "Policy"; | 
| + case UMA: | 
| + return "UMA"; | 
| + case GOOGLE_APIS: | 
| + return "GoogleAPIs"; | 
| + case DOMAIN_RELIABILITY: | 
| + return "DomainReliability"; | 
| + case PROFILE_DOWNLOADER: | 
| + return "ProfileDownloader"; | 
| + case URL_TRACKER: | 
| + return "URLTracker"; | 
| + case AUTOFILL: | 
| + return "Autofill"; | 
| + case VARIATIONS: | 
| + return "Variations"; | 
| + case DEVICE_MANAGEMENT: | 
| + return "DeviceManagement"; | 
| + case SPELL_CHECKER: | 
| + return "SpellChecker"; | 
| + case GEO_LOCATION: | 
| + return "GeoLocation"; | 
| default: | 
| 
Ilya Sherman
2015/09/04 22:10:39
nit: Please remove the default case -- that way, t
 
amohammadkhan
2015/09/04 23:03:16
Done.
 | 
| NOTREACHED() << "Unknown service type in DataUseUserData"; | 
| } |