Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: components/data_use_measurement/core/data_use_user_data.cc

Issue 1330443002: Report data usage UMA for Chrome services (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewArchServices
Patch Set: Reverting the changes in //google_apis Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/core/data_use_user_data.cc
diff --git a/components/data_use_measurement/core/data_use_user_data.cc b/components/data_use_measurement/core/data_use_user_data.cc
index c6ad360a9afb488bc6e0a723de7cec8ab9678ff1..8fbe619ba62078954b6aff29aaa7d10312927444 100644
--- a/components/data_use_measurement/core/data_use_user_data.cc
+++ b/components/data_use_measurement/core/data_use_user_data.cc
@@ -31,9 +31,38 @@ const char* DataUseUserData::GetServiceName(
return "Suggestions";
case NOT_TAGGED:
return "NotTagged";
- default:
- NOTREACHED() << "Unknown service type in DataUseUserData";
+ case TRANSLATE:
+ return "Translate";
+ case SYNC:
+ return "Sync";
+ case OMNIBOX:
+ return "Omnibox";
+ case INVALIDATION:
+ return "Invalidation";
+ case RAPPOR:
+ return "Rappor";
+ case POLICY:
+ return "Policy";
+ case UMA:
+ return "UMA";
+ case GOOGLE_APIS:
+ return "GoogleAPIs";
+ case DOMAIN_RELIABILITY:
+ return "DomainReliability";
+ case PROFILE_DOWNLOADER:
+ return "ProfileDownloader";
+ case GOOGLE_URL_TRACKER:
+ return "GoogleURLTracker";
+ case AUTOFILL:
+ return "Autofill";
+ case VARIATIONS:
+ return "Variations";
+ case SPELL_CHECKER:
+ return "SpellChecker";
+ case GEO_LOCATION:
+ return "GeoLocation";
}
+ NOTREACHED() << "Unknown service type in DataUseUserData";
Ilya Sherman 2015/09/08 21:45:25 nit: Please omit at least the string after the NOT
amohammadkhan 2015/09/08 23:28:31 Done.
return "INVALID";
}

Powered by Google App Engine
This is Rietveld 408576698