Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1330433003: [Line Layout API] Add textStartOffset to LineLayoutText (Closed)

Created:
5 years, 3 months ago by pilgrim_google
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Line Layout API] Add textStartOffset to LineLayoutText This CL updates callers in LayoutText.cpp. BUG=499321 Committed: https://crrev.com/0285a747847f7c2794d75c2d4d475119eb91372d git-svn-id: svn://svn.chromium.org/blink/trunk@201988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : ignore previous patch, review hypnotoad #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M Source/core/layout/LayoutText.cpp View 1 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/layout/api/LineLayoutText.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pilgrim_google
5 years, 3 months ago (2015-09-09 15:09:02 UTC) #2
eae
LGTM
5 years, 3 months ago (2015-09-09 16:52:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330433003/20001
5 years, 3 months ago (2015-09-09 17:08:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201988
5 years, 3 months ago (2015-09-09 18:26:47 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:01:14 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0285a747847f7c2794d75c2d4d475119eb91372d

Powered by Google App Engine
This is Rietveld 408576698