[Extensions Toolbar] Protect against crazy bounds

chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.h"
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 429 matching lines @@
   EXPECT_EQ(gfx::Rect(kSpacing, kIconHeight, kIconWidth, kIconHeight),
             overflow_bar()->GetFrameForIndex(6));
 
   // Check with > 2 rows.
   toolbar_model()->SetVisibleIconCount(0);
   EXPECT_EQ(gfx::Rect(kSpacing, 0, kIconWidth, kIconHeight),
             overflow_bar()->GetFrameForIndex(0));
   EXPECT_EQ(gfx::Rect(kSpacing, kIconHeight * 2, kIconWidth, kIconHeight),
             overflow_bar()->GetFrameForIndex(6));
 }
+
+TEST_F(ToolbarActionsBarRedesignUnitTest, TestStartAndEndIndexes) {
+  for (int i = 0; i < 3; ++i) {
+    CreateAndAddExtension(
+        base::StringPrintf("extension %d", i),
+        extensions::extension_action_test_util::BROWSER_ACTION);
+  }
+  // At the start, all icons should be present on the main bar, and no
+  // overflow should be needed.
+  EXPECT_EQ(3u, toolbar_actions_bar()->GetIconCount());
+  EXPECT_EQ(0u, toolbar_actions_bar()->GetStartIndexInBounds());
+  EXPECT_EQ(3u, toolbar_actions_bar()->GetEndIndexInBounds());
+  EXPECT_EQ(3u, overflow_bar()->GetStartIndexInBounds());
+  EXPECT_EQ(3u, overflow_bar()->GetEndIndexInBounds());
+  EXPECT_FALSE(toolbar_actions_bar()->NeedsOverflow());
+
+  // Shrink the width of the view to be a little over enough for one icon.
+  browser_action_test_util()->SetWidth(ToolbarActionsBar::IconWidth(true) + 5);
+  // Tricky: GetIconCount() is what we use to determine our preferred size,
+  // stored pref size, etc, and should not be affected by a minimum size that is
+  // too small to show everything. It should remain constant.
+  EXPECT_EQ(3u, toolbar_actions_bar()->GetIconCount());
+  // The main container should display only the first icon, with the overflow
+  // displaying the rest.
+  EXPECT_EQ(0u, toolbar_actions_bar()->GetStartIndexInBounds());
+  EXPECT_EQ(1u, toolbar_actions_bar()->GetEndIndexInBounds());
+  EXPECT_EQ(1u, overflow_bar()->GetStartIndexInBounds());
+  EXPECT_EQ(3u, overflow_bar()->GetEndIndexInBounds());
+  EXPECT_TRUE(toolbar_actions_bar()->NeedsOverflow());
+
+  // Shrink the container again to be too small to display even one icon.
+  // The overflow container should be displaying everything.
+  browser_action_test_util()->SetWidth(ToolbarActionsBar::IconWidth(true) - 10);
+  EXPECT_EQ(3u, toolbar_actions_bar()->GetIconCount());
+  EXPECT_EQ(0u, toolbar_actions_bar()->GetStartIndexInBounds());
+  EXPECT_EQ(0u, toolbar_actions_bar()->GetEndIndexInBounds());
+  EXPECT_EQ(0u, overflow_bar()->GetStartIndexInBounds());
+  EXPECT_EQ(3u, overflow_bar()->GetEndIndexInBounds());
+  EXPECT_TRUE(toolbar_actions_bar()->NeedsOverflow());
+
+  // Set the width back to the preferred width. All should be back to normal.
+  browser_action_test_util()->SetWidth(
+      toolbar_actions_bar()->GetPreferredSize().width());
+  EXPECT_EQ(3u, toolbar_actions_bar()->GetIconCount());
+  EXPECT_EQ(0u, toolbar_actions_bar()->GetStartIndexInBounds());
+  EXPECT_EQ(3u, toolbar_actions_bar()->GetEndIndexInBounds());
+  EXPECT_EQ(3u, overflow_bar()->GetStartIndexInBounds());
+  EXPECT_EQ(3u, overflow_bar()->GetEndIndexInBounds());
+  EXPECT_FALSE(toolbar_actions_bar()->NeedsOverflow());
+}