[Extensions Toolbar] Protect against crazy bounds

chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h"
 
 #include "base/basictypes.h"
 #include "base/mac/bundle_locations.h"
 #include "base/strings/string16.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 20 matching lines @@
 #include "content/public/browser/user_metrics.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/models/menu_model.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace {
 // Padding amounts on the left/right of a custom menu item (like the browser
 // actions overflow container).
 const int kLeftPadding = 16;
 const int kRightPadding = 10;
+
+// In *very* extreme cases, it's possible that there are so many overflowed
+// actions, we won't be able to show them all. Cap the height so that the
+// overflow won't make the menu larger than the height of the screen.
+// Note: With this height, we can show 104 actions. Less than 0.0002% of our
+// users will be affected.
+const int kMaxOverflowContainerHeight = 416;
 }
 
 namespace wrench_menu_controller {
 const CGFloat kWrenchBubblePointOffsetY = 6;
 }
 
 using base::UserMetricsAction;
 
 @interface WrenchMenuController (Private)
 - (void)createModel;
@@ skipping 220 matching lines @@
   [[self menu] setMinimumWidth:menuWidth];
   gfx::Size preferredContainerSize =
       [browserActionsController_ sizeForOverflowWidth:maxContainerWidth];
 
   // Set the origins and preferred size for the container.
   // View hierarchy is as follows (from parent > child):
   // |view| > |anonymous view| > containerView. We have to set the origin
   // and size of each for it display properly.
   // The parent views each have a size of the full width of the menu, so we can
   // properly position the container.
-  NSSize parentSize = NSMakeSize(menuWidth, preferredContainerSize.height());
+  NSSize parentSize = NSMakeSize(menuWidth,
+                                 std::min(preferredContainerSize.height(),
+                                          kMaxOverflowContainerHeight));
   [view setFrameSize:parentSize];
   [[containerView superview] setFrameSize:parentSize];
 
   // The container view gets its preferred size.
   [containerView setFrameSize:NSMakeSize(preferredContainerSize.width(),
                                          preferredContainerSize.height())];
   [browserActionsController_ update];
 
   [view setFrameOrigin:NSZeroPoint];
   [[containerView superview] setFrameOrigin:NSZeroPoint];
@@ skipping 257 matching lines @@
   // (and thus, after all our ability to adjust it normally). Throw in the
   // towel, and simply don't let the frame move from where it's supposed to be.
   // TODO(devlin): Yet another Cocoa hack. It'd be good to find a workaround,
   // but unlikely unless we replace the Cocoa menu implementation.
   NSView* containerSuperview = [overflowActionsContainerView_ superview];
   if (NSMinX([containerSuperview frame]) != 0)
     [containerSuperview setFrameOrigin:NSZeroPoint];
 }
 
 @end  // @implementation WrenchMenuButtonViewController