Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 133033002: Port manifest query tests from nacl_integration to browser_tests. (Closed)

Created:
6 years, 11 months ago by Nick Bray (chromium)
Modified:
6 years, 11 months ago
Reviewers:
bbudge, bradnelson, bradn
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Port manifest query tests from nacl_integration to browser_tests. fgets was refactored to read because fdopen was returning null in glibc. These tests were disabled for glibc without explanation, so working around this bug loses no coverage. BUG=154400 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244313

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -1478 lines) Patch
A + chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
A + chrome/test/data/nacl/manifest_file/irt_manifest_file_test.html View 1 chunk +18 lines, -10 lines 0 comments Download
A + chrome/test/data/nacl/manifest_file/pm_manifest_file_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/data/nacl/manifest_file/pm_manifest_file_test.html View 1 chunk +18 lines, -11 lines 0 comments Download
A + chrome/test/data/nacl/manifest_file/pm_pre_init_manifest_file_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
A + chrome/test/data/nacl/manifest_file/pm_pre_init_manifest_file_test.html View 1 chunk +18 lines, -10 lines 0 comments Download
A + chrome/test/data/nacl/manifest_file/test_file.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/nacl/nacl_test_data.gyp View 2 chunks +139 lines, -0 lines 2 comments Download
M chrome/test/nacl/nacl_browsertest.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M ppapi/native_client/chrome_main.scons View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/irt_manifest_file.nmf View 1 chunk +0 lines, -17 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/irt_manifest_file_test.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/irt_manifest_file_test.html View 1 chunk +0 lines, -50 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/nacl.scons View 1 chunk +0 lines, -106 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/pm_manifest_file.nmf View 1 chunk +0 lines, -17 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/pm_manifest_file_test.cc View 1 chunk +0 lines, -669 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/pm_manifest_file_test.html View 1 chunk +0 lines, -98 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/pm_pre_init_manifest_file.nmf View 1 chunk +0 lines, -17 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/pm_pre_init_manifest_file_test.cc View 1 chunk +0 lines, -267 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/pm_pre_init_manifest_file_test.html View 1 chunk +0 lines, -70 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/manifest_file/test_file.txt View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_nacl_test_common.gypi View 5 chunks +13 lines, -3 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
Nick Bray (chromium)
Brad as primary reviewer. Bill as ppapi/ OWNER. You guys stole my gyp file. I'd ...
6 years, 11 months ago (2014-01-10 01:33:42 UTC) #1
bbudge
ppapi Rubber Stamp LGTM
6 years, 11 months ago (2014-01-10 01:39:01 UTC) #2
bradn
https://codereview.chromium.org/133033002/diff/1/chrome/test/data/nacl/nacl_test_data.gyp File chrome/test/data/nacl/nacl_test_data.gyp (right): https://codereview.chromium.org/133033002/diff/1/chrome/test/data/nacl/nacl_test_data.gyp#newcode600 chrome/test/data/nacl/nacl_test_data.gyp:600: '-xnmf says hello world:test_file.txt', what's up with this says ...
6 years, 11 months ago (2014-01-10 17:48:36 UTC) #3
bradnelson
lgtm https://codereview.chromium.org/133033002/diff/1/chrome/test/data/nacl/nacl_test_data.gyp File chrome/test/data/nacl/nacl_test_data.gyp (right): https://codereview.chromium.org/133033002/diff/1/chrome/test/data/nacl/nacl_test_data.gyp#newcode600 chrome/test/data/nacl/nacl_test_data.gyp:600: '-xnmf says hello world:test_file.txt', On 2014/01/10 17:48:36, bradn ...
6 years, 11 months ago (2014-01-10 17:54:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/133033002/1
6 years, 11 months ago (2014-01-10 18:06:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244894
6 years, 11 months ago (2014-01-10 21:25:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/133033002/1
6 years, 11 months ago (2014-01-10 21:45:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/133033002/1
6 years, 11 months ago (2014-01-10 23:41:38 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 02:27:12 UTC) #9
Message was sent while issue was closed.
Change committed as 244313

Powered by Google App Engine
This is Rietveld 408576698