Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: ui/events/event.h

Issue 1330233005: Remove outdated TODOs for issue 337824. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | ui/events/gesture_event_details.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event.h
diff --git a/ui/events/event.h b/ui/events/event.h
index ebc4708090eb26cd98ab768f6224447b3283f505..eff791345993767b349e0ed3d9fa211e0e4e0299 100644
--- a/ui/events/event.h
+++ b/ui/events/event.h
@@ -263,8 +263,6 @@ class EVENTS_EXPORT LocatedEvent : public Event {
float x() const { return location_.x(); }
float y() const { return location_.y(); }
void set_location(const gfx::PointF& location) { location_ = location; }
- // TODO(tdresser): Always return floating point location. See
- // crbug.com/337824.
gfx::Point location() const { return gfx::ToFlooredPoint(location_); }
const gfx::PointF& location_f() const { return location_; }
void set_root_location(const gfx::PointF& root_location) {
@@ -285,8 +283,6 @@ class EVENTS_EXPORT LocatedEvent : public Event {
template <class T> void ConvertLocationToTarget(T* source, T* target) {
if (!target || target == source)
return;
- // TODO(tdresser): Rewrite ConvertPointToTarget to use PointF. See
- // crbug.com/337824.
gfx::Point offset = gfx::ToFlooredPoint(location_);
T::ConvertPointToTarget(source, target, &offset);
gfx::Vector2d diff = gfx::ToFlooredPoint(location_) - offset;
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | ui/events/gesture_event_details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698