Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1330233004: Fix for v8:4380 introduced a regression in Octane crypto. (Closed)

Created:
5 years, 3 months ago by mvstanton
Modified:
5 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix for v8:4380 introduced a regression in Octane crypto. Narrowed the scope of the fix, to make a best effort to avoid DEOPT in case the hole is loaded, but not to permute the choice of a consolidated load in case that effort fails. BUG=chromium:530005 LOG=N Committed: https://crrev.com/ebd16fd89d5a8881e28dbda81ab536c876e783f2 Cr-Commit-Position: refs/heads/master@{#30677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M src/hydrogen.cc View 1 chunk +20 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mvstanton
Hi Jakob, Implementing your insightful off-the-cuff comment yesterday proves to be the right thing. :) ...
5 years, 3 months ago (2015-09-10 10:01:58 UTC) #2
Jakob Kummerow
lgtm
5 years, 3 months ago (2015-09-10 10:55:06 UTC) #3
Jakob Kummerow
Reminder: bugdroid wants "chromium:" on the BUG= line. Fixed that for ya.
5 years, 3 months ago (2015-09-10 10:56:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330233004/1
5 years, 3 months ago (2015-09-10 11:36:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 11:38:14 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 11:38:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebd16fd89d5a8881e28dbda81ab536c876e783f2
Cr-Commit-Position: refs/heads/master@{#30677}

Powered by Google App Engine
This is Rietveld 408576698