Chromium Code Reviews Chromium Code Reviews
Issue
1330233003:
Revert of Avoid style clobbering in setCompositionFromExistingText. (Closed)
DescriptionRevert of Avoid style clobbering in setCompositionFromExistingText. (patchset #8 id:140001 of https://codereview.chromium.org/1325563002/ )
Reason for revert:
This patch caused repeatable failures on WebKit Linux Leaks (starting at https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/14049). Verified locally by adding `--enable-leak-detection` to the test runner on my linux machine. Reverting this patch locally fixed the leaks.
Original issue's description:
> Avoid style clobbering in setCompositionFromExistingText.
>
> This patch extends compositions to be able to span multiple nodes. This involves
> two main changes: first, compositions are switched to being stored as a Range, not
> a Node plus two offsets. Second, the underline painting now uses DocumentMarkerController
> (which is already multi-node) instead of a custom composition-specific path.
>
> As a result, we can remove the hack in setCompositionFromExistingText that clobbered
> the text to shoehorn it into a single node, which would cause style loss. This
> is now able to span the existing text regardless of how complicated it is.
>
> TEST=webkit_unit_tests --gtest_filter=DocumentMarkerControllerTest.UpdateRenderedRectsForComposition
> TEST=webkit_unit_tests --gtest_filter=WebViewTest.SetCompositionFromExistingTextInRichText
> BUG=488628
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201994
TBR=pdr@chromium.org,yosin@chromium.org,aelias@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488628
Committed: https://crrev.com/5209cf506681777157fbcc4a980109e9ef246f1a
git-svn-id: svn://svn.chromium.org/blink/trunk@202042 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Patch Set 1 #Messages
Total messages: 4 (0 generated)
|
