Issue 1330173002: gyp_pdfium should use ninja by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1330173002: gyp_pdfium should use ninja by default. (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez, Nico

CC:
pdfium-reviews_googlegroups.com, Tom Sepez

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	build/gyp_pdfium	View		2 chunks	+8 lines, -3 lines	0 comments	Download

Total messages: 7 (2 generated)

Lei Zhang

Should we default to ninja? I can update https://code.google.com/p/pdfium/wiki/Build if this lands.

5 years, 3 months ago (2015-09-09 21:38:19 UTC) #2

Tom Sepez

LGTM. If someone came to me with a make bug, for example, we'd tell them ...

5 years, 3 months ago (2015-09-09 22:27:13 UTC) #4

Lei Zhang

On 2015/09/09 22:33:23, Nico wrote: > lgtm \o/ https://code.google.com/p/pdfium/wiki/Build updated -> landing.

5 years, 3 months ago (2015-09-15 21:53:37 UTC) #6

Lei Zhang

5 years, 3 months ago (2015-09-15 22:41:29 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8b1cb99abd4dcff132367fe338df38e48971bd1d (presubmit successful).