Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1330163005: Fix build with system icu (Closed)

Created:
5 years, 3 months ago by Paweł Hajdan Jr.
Modified:
5 years, 3 months ago
Reviewers:
drott
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/platform/fonts/ScriptRunIterator.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paweł Hajdan Jr.
5 years, 3 months ago (2015-09-09 13:59:23 UTC) #2
drott
LGTM, sorry for the trouble.
5 years, 3 months ago (2015-09-09 14:35:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330163005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330163005/1
5 years, 3 months ago (2015-09-09 14:42:52 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 15:15:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201980

Powered by Google App Engine
This is Rietveld 408576698