src/isolate.cc - Issue 1330153003: Adding template parameter to PrototypeIterator GetCurrent for casting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 1330153003: Adding template parameter to PrototypeIterator GetCurrent for casting (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifications Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 80024cad277bacd3c111f2eb93bbc6bb75d8dcba..b8b3c2613279823610462c669c44e2310a0cedb3 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -1348,7 +1348,7 @@ bool Isolate::IsErrorObject(Handle<Object> obj) {

for (PrototypeIterator iter(this, *obj, PrototypeIterator::START_AT_RECEIVER);

!iter.IsAtEnd(); iter.Advance()) {

if (iter.GetCurrent()->IsJSProxy()) return false;

- if (JSObject::cast(iter.GetCurrent())->map()->GetConstructor() ==

+ if (iter.GetCurrent<JSObject>()->map()->GetConstructor() ==

*error_constructor) {

return true;

}

« no previous file with comments | « src/ic/handler-compiler.cc ('k') | src/lookup.cc » ('j') | no next file with comments »