Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/debug/debug-evaluate.cc

Issue 1330153003: Adding template parameter to PrototypeIterator GetCurrent for casting (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: simplifications Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug-evaluate.h" 5 #include "src/debug/debug-evaluate.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/contexts.h" 8 #include "src/contexts.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/debug/debug-frames.h" 10 #include "src/debug/debug-frames.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 Handle<Object> result; 99 Handle<Object> result;
100 ASSIGN_RETURN_ON_EXCEPTION( 100 ASSIGN_RETURN_ON_EXCEPTION(
101 isolate, result, Execution::Call(isolate, eval_fun, receiver, 0, NULL), 101 isolate, result, Execution::Call(isolate, eval_fun, receiver, 0, NULL),
102 Object); 102 Object);
103 103
104 // Skip the global proxy as it has no properties and always delegates to the 104 // Skip the global proxy as it has no properties and always delegates to the
105 // real global object. 105 // real global object.
106 if (result->IsJSGlobalProxy()) { 106 if (result->IsJSGlobalProxy()) {
107 PrototypeIterator iter(isolate, result); 107 PrototypeIterator iter(isolate, result);
108 // TODO(verwaest): This will crash when the global proxy is detached. 108 // TODO(verwaest): This will crash when the global proxy is detached.
109 result = Handle<JSObject>::cast(PrototypeIterator::GetCurrent(iter)); 109 result = PrototypeIterator::GetCurrent<JSObject>(iter);
110 } 110 }
111 111
112 return result; 112 return result;
113 } 113 }
114 114
115 115
116 DebugEvaluate::ContextBuilder::ContextBuilder(Isolate* isolate, 116 DebugEvaluate::ContextBuilder::ContextBuilder(Isolate* isolate,
117 JavaScriptFrame* frame, 117 JavaScriptFrame* frame,
118 int inlined_jsframe_index) 118 int inlined_jsframe_index)
119 : isolate_(isolate), 119 : isolate_(isolate),
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 // to materialize. 305 // to materialize.
306 return target; 306 return target;
307 } 307 }
308 308
309 return isolate_->factory()->NewCatchContext( 309 return isolate_->factory()->NewCatchContext(
310 function, target, isolate_->factory()->this_string(), receiver); 310 function, target, isolate_->factory()->this_string(), receiver);
311 } 311 }
312 312
313 } // namespace internal 313 } // namespace internal
314 } // namespace v8 314 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698