Remove render process and WebContents notifications from background printing.

Remove render process and WebContents notifications from background printing.

BUG=170921
TEST=everything still works, bug 100806 doesn't regress

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244391

[Lei Zhang, 2014-01-11 02:35:22]

lgtm with some nits.

Having per-WC RenderProcess observers is so much saner.

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
File chrome/browser/printing/background_printing_manager.cc (right):

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
chrome/browser/printing/background_printing_manager.cc:57: // The might be some
WebContentses still in |printing_contents_set_| at this
|printing_contents_set_| -> |printing_contents_map_|

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
chrome/browser/printing/background_printing_manager.cc:71: Observer* observer =
new Observer(this, preview_dialog);
nit: no need for the |observer| variable

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
chrome/browser/printing/background_printing_manager.cc:101: if
(!ContainsKey(printing_contents_map_, preview_contents)) {
If you save the iterator here instead, you can re-use the iterator on lines 111
and 112.

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
File chrome/browser/printing/background_printing_manager.h (right):

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
chrome/browser/printing/background_printing_manager.h:41: // Returns true if
|printing_contents_set_| contains |preview_dialog|.
|printing_contents_set_| -> |printing_contents_map_|

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
chrome/browser/printing/background_printing_manager.h:46: //
WebContentsSet::const_iterator begin();
remove commented out code?

[commit-bot: I haz the power, 2014-01-11 19:12:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/133013002/190001

[Avi (use Gerrit), 2014-01-11 19:12:49]

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
File chrome/browser/printing/background_printing_manager.cc (right):

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
chrome/browser/printing/background_printing_manager.cc:57: // The might be some
WebContentses still in |printing_contents_set_| at this
On 2014/01/11 02:35:22, Lei Zhang wrote:
> |printing_contents_set_| -> |printing_contents_map_|

Done.

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
chrome/browser/printing/background_printing_manager.cc:71: Observer* observer =
new Observer(this, preview_dialog);
On 2014/01/11 02:35:22, Lei Zhang wrote:
> nit: no need for the |observer| variable

Done.

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
chrome/browser/printing/background_printing_manager.cc:101: if
(!ContainsKey(printing_contents_map_, preview_contents)) {
On 2014/01/11 02:35:22, Lei Zhang wrote:
> If you save the iterator here instead, you can re-use the iterator on lines
111
> and 112.

Done.

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
File chrome/browser/printing/background_printing_manager.h (right):

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
chrome/browser/printing/background_printing_manager.h:41: // Returns true if
|printing_contents_set_| contains |preview_dialog|.
On 2014/01/11 02:35:22, Lei Zhang wrote:
> |printing_contents_set_| -> |printing_contents_map_|

Done.

https://codereview.chromium.org/133013002/diff/90001/chrome/browser/printing/...
chrome/browser/printing/background_printing_manager.h:46: //
WebContentsSet::const_iterator begin();
On 2014/01/11 02:35:22, Lei Zhang wrote:
> remove commented out code?

Oops, yeah.

[commit-bot: I haz the power, 2014-01-11 23:22:42]

Change committed as 244391