Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1330063002: Update documentation of colors on Status. (Closed)

Created:
5 years, 3 months ago by dogben
Modified:
5 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update documentation of colors on Status. BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1330063002 Committed: https://skia.googlesource.com/skia/+/00c3252bb9bcb669bea6e9e0d06e6a3d8ba0d593

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix bullets. #

Patch Set 3 : Fix bullets. #

Patch Set 4 : Fix bullets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M site/dev/testing/buildbot.md View 1 2 3 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dogben
5 years, 3 months ago (2015-09-08 19:42:40 UTC) #2
borenet
LGTM https://codereview.chromium.org/1330063002/diff/1/site/dev/testing/buildbot.md File site/dev/testing/buildbot.md (right): https://codereview.chromium.org/1330063002/diff/1/site/dev/testing/buildbot.md#newcode75 site/dev/testing/buildbot.md:75: - orange: failure It looks more red than ...
5 years, 3 months ago (2015-09-08 19:44:32 UTC) #3
dogben
On 2015/09/08 at 19:44:32, borenet wrote: > LGTM > > https://codereview.chromium.org/1330063002/diff/1/site/dev/testing/buildbot.md > File site/dev/testing/buildbot.md (right): ...
5 years, 3 months ago (2015-09-08 19:47:19 UTC) #4
borenet
On 2015/09/08 19:47:19, Ben Wagner wrote: > On 2015/09/08 at 19:44:32, borenet wrote: > > ...
5 years, 3 months ago (2015-09-08 19:49:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330063002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330063002/60001
5 years, 3 months ago (2015-09-08 19:50:55 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 19:51:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/00c3252bb9bcb669bea6e9e0d06e6a3d8ba0d593

Powered by Google App Engine
This is Rietveld 408576698