Make ErrorConsole catch errors from Extension WebContents Views

chrome/browser/extensions/extension_web_contents_observer.cc

Index: chrome/browser/extensions/extension_web_contents_observer.cc
diff --git a/chrome/browser/extensions/extension_web_contents_observer.cc b/chrome/browser/extensions/extension_web_contents_observer.cc
index 228ea99230b30466855e415b6acb0aa01eccc06a..5e193afb35022365fd1829fa1bbe75b06c3e98b0 100644
--- a/chrome/browser/extensions/extension_web_contents_observer.cc
+++ b/chrome/browser/extensions/extension_web_contents_observer.cc
@@ -5,10 +5,12 @@
 #include "chrome/browser/extensions/extension_web_contents_observer.h"
 
 #include "chrome/browser/extensions/api/messaging/message_service.h"
+#include "chrome/browser/extensions/error_console/error_console.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/common/extensions/api/messaging/message.h"
 #include "chrome/common/extensions/extension_messages.h"
+#include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/child_process_security_policy.h"
 #include "content/public/browser/render_process_host.h"
@@ -18,6 +20,7 @@
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/view_type_utils.h"
 #include "extensions/common/constants.h"
+#include "extensions/common/extension_urls.h"
 
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(extensions::ExtensionWebContentsObserver);
 
@@ -36,7 +39,7 @@ void ExtensionWebContentsObserver::RenderViewCreated(
     content::RenderViewHost* render_view_host) {
   render_view_host->Send(new ExtensionMsg_NotifyRenderViewType(
       render_view_host->GetRoutingID(),
-      extensions::GetViewType(web_contents())));
+      GetViewType(web_contents())));
 
   const Extension* extension = GetExtension(render_view_host);
   if (!extension)
@@ -95,11 +98,36 @@ bool ExtensionWebContentsObserver::OnMessageReceived(
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(ExtensionWebContentsObserver, message)
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_PostMessage, OnPostMessage)
+    IPC_MESSAGE_HANDLER(ChromeViewHostMsg_DetailedConsoleMessageAdded,
+                        OnDetailedConsoleMessageAdded)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
+void ExtensionWebContentsObserver::OnDetailedConsoleMessageAdded(
+    const base::string16& message,
+    const base::string16& source,
+    const StackTrace& stack_trace,
+    int32 severity_level) {
+  if (IsSourceFromAnExtension(source)) {
+    content::RenderViewHost* rvh = web_contents()->GetRenderViewHost();
+    ErrorConsole::Get(Profile::FromBrowserContext(browser_context_))->
+        ReportError(
+            scoped_ptr<ExtensionError>(new RuntimeError(
+                std::string(),
+                browser_context_->IsOffTheRecord(),
+                source,
+                message,
+                stack_trace,
+                web_contents() ?
+                    web_contents()->GetLastCommittedURL() : GURL::EmptyGURL(),
+                static_cast<logging::LogSeverity>(severity_level),
+                rvh->GetRoutingID(),
+                rvh->GetProcess()->GetID())));
+  }
+}
+
 void ExtensionWebContentsObserver::OnPostMessage(int port_id,
                                                  const Message& message) {
   MessageService* message_service = MessageService::Get(browser_context_);