Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1329963002: Document the --trace-startup shell flag. (Closed)

Created:
5 years, 3 months ago by etiennej
Modified:
5 years, 3 months ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M mojo/devtools/common/README.md View 1 2 1 chunk +15 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
etiennej
5 years, 3 months ago (2015-09-07 08:33:18 UTC) #1
ppi
https://codereview.chromium.org/1329963002/diff/1/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1329963002/diff/1/mojo/devtools/common/README.md#newcode72 mojo/devtools/common/README.md:72: mojo_run --debugger --trace-startup APP_URL [--android] You don't actually need ...
5 years, 3 months ago (2015-09-07 08:42:22 UTC) #2
etiennej
https://codereview.chromium.org/1329963002/diff/1/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1329963002/diff/1/mojo/devtools/common/README.md#newcode72 mojo/devtools/common/README.md:72: mojo_run --debugger --trace-startup APP_URL [--android] On 2015/09/07 08:42:21, ppi ...
5 years, 3 months ago (2015-09-07 08:43:52 UTC) #3
ppi
https://codereview.chromium.org/1329963002/diff/20001/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1329963002/diff/20001/mojo/devtools/common/README.md#newcode72 mojo/devtools/common/README.md:72: mojo_run --trace-startup APP_URL [--android] Actually, this should not be ...
5 years, 3 months ago (2015-09-07 08:56:29 UTC) #4
etiennej
https://codereview.chromium.org/1329963002/diff/20001/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1329963002/diff/20001/mojo/devtools/common/README.md#newcode72 mojo/devtools/common/README.md:72: mojo_run --trace-startup APP_URL [--android] On 2015/09/07 08:56:29, ppi wrote: ...
5 years, 3 months ago (2015-09-07 09:05:49 UTC) #5
etiennej
https://codereview.chromium.org/1329963002/diff/20001/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1329963002/diff/20001/mojo/devtools/common/README.md#newcode72 mojo/devtools/common/README.md:72: mojo_run --trace-startup APP_URL [--android] On 2015/09/07 09:05:49, etiennej wrote: ...
5 years, 3 months ago (2015-09-07 10:41:51 UTC) #6
ppi
lgtm
5 years, 3 months ago (2015-09-07 10:47:56 UTC) #7
etiennej
5 years, 3 months ago (2015-09-07 11:05:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
94c26b19d3d2580bd41b516b08ddbb1079dfa02b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698