Issue 132993011: A64: Do not initialize VM twice in test-assembler-a64.cc.

PTAL, this fixes cctest/test-assembler-a64/* failures. https://codereview.chromium.org/132993011/diff/40001/test/cctest/test-assembler-a64.cc File test/cctest/test-assembler-a64.cc (right): https://codereview.chromium.org/132993011/diff/40001/test/cctest/test-assembler-a64.cc#newcode1128 test/cctest/test-assembler-a64.cc:1128: CcTest::InitializeVM(); Is this OK, ...

6 years, 10 months ago (2014-02-04 18:35:58 UTC) #1

m.m.capewell

https://codereview.chromium.org/132993011/diff/40001/test/cctest/test-assembler-a64.cc File test/cctest/test-assembler-a64.cc (right): https://codereview.chromium.org/132993011/diff/40001/test/cctest/test-assembler-a64.cc#newcode1128 test/cctest/test-assembler-a64.cc:1128: CcTest::InitializeVM(); On 2014/02/04 18:35:59, ulan wrote: > Is this ...

6 years, 10 months ago (2014-02-04 18:48:33 UTC) #2

ulan

Jochen also uploaded a fix for this issue: https://codereview.chromium.org/154713002/ Please lgtm the one that you ...

6 years, 10 months ago (2014-02-05 08:24:53 UTC) #3

jochen (gone - plz use gerrit)

6 years, 10 months ago (2014-02-05 08:56:08 UTC) #4

On 2014/02/04 18:48:33, m.m.capewell wrote:
>
https://codereview.chromium.org/132993011/diff/40001/test/cctest/test-assembl...
> File test/cctest/test-assembler-a64.cc (right):
> 
>
https://codereview.chromium.org/132993011/diff/40001/test/cctest/test-assembl...
> test/cctest/test-assembler-a64.cc:1128: CcTest::InitializeVM();
> On 2014/02/04 18:35:59, ulan wrote:
> > Is this OK, or should I put hide it behind macro?
> 
> Is it possible to hide it in the TEST macro?

here's an alternative fix: https://codereview.chromium.org/154713002/

Expand Messages | Collapse Messages