Issue 132993009: Use mock temp file in profiler tests

Issue 132993009: Use mock temp file in profiler tests (Closed)

Created:
6 years, 11 months ago by yurys

Modified:
6 years, 11 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use mock temp file in profiler tests Mock temp file implementation is used in all inspector tests instead of the real implementation based on temporary filesystem which (unlike temp fs in regular DevTools window) has limited quota which is often exceeded in the tests. This should fix flakiness in the following tests: inspector/profiler/heap-snapshot-loader.html inspector/profiler/cpu-profiler-save-load.html Also a bug in BufferedTempFileWriter.close was fixed. TempFile.getFile was replaced with writeToOutputSteam which operates on types defined in DevTools and simplifies mocks. BUG=330617, 333860 R=alph@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165136

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed clearHeapProfilerTempStorage step #

Patch Set 3 : Addressed comment #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -52 lines)			Patch
M	LayoutTests/TestExpectations	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	LayoutTests/http/tests/inspector/inspector-test.js	View		1 chunk	+73 lines, -0 lines	0 comments	Download
M	LayoutTests/inspector/profiler/heap-snapshot-loader.html	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download
M	LayoutTests/inspector/profiler/heap-snapshot-loader-expected.txt	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotView.js	View	1 2	2 chunks	+5 lines, -23 lines	0 comments	Download
M	Source/devtools/front_end/TempFile.js	View	1 2	3 chunks	+18 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

alph

lgtm https://codereview.chromium.org/132993009/diff/1/Source/devtools/front_end/TempFile.js File Source/devtools/front_end/TempFile.js (right): https://codereview.chromium.org/132993009/diff/1/Source/devtools/front_end/TempFile.js#newcode188 Source/devtools/front_end/TempFile.js:188: var reader = new WebInspector.ChunkedFileReader(file, 10*1000*1000, delegate) missing ...

6 years, 11 months ago (2014-01-15 15:29:31 UTC) #2

yurys

https://codereview.chromium.org/132993009/diff/1/Source/devtools/front_end/TempFile.js File Source/devtools/front_end/TempFile.js (right): https://codereview.chromium.org/132993009/diff/1/Source/devtools/front_end/TempFile.js#newcode188 Source/devtools/front_end/TempFile.js:188: var reader = new WebInspector.ChunkedFileReader(file, 10*1000*1000, delegate) On 2014/01/15 ...

6 years, 11 months ago (2014-01-15 15:39:11 UTC) #3

yurys

6 years, 11 months ago (2014-01-15 15:40:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r165136 (presubmit successful).

Expand Messages | Collapse Messages