Source/core/frame/FrameView.cpp - Issue 1329853004: Include viewport visibility checks for autoplay experiment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1329853004: Include viewport visibility checks for autoplay experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@autoplay_step1

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/video-autoplay-experiment-modes-expected.txt ('k') | Source/core/html/AutoplayExperimentConfig.h » ('j') | Source/core/html/AutoplayExperimentConfig.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index cdfa3a72851e8005b125f67f28d907238286c97d..bdaf3bd54f4cff0fe148899709989d546c638adb 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -2478,6 +2478,11 @@ void FrameView::updateLifecyclePhasesInternal(LifeCycleUpdateOption phases)

ASSERT(!view->hasPendingSelection());

ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationClean

|| (RuntimeEnabledFeatures::slimmingPaintV2Enabled() && lifecycle().state() == DocumentLifecycle::CompositingForSlimmingPaintV2Clean));

+ // Temporary callback for crbug.com/487345,402044

+ // TODO(ojan): Make this more general to be used by PositionObserver

+ // and rAF throttling.

+ view->sendMediaPositionChangeNotifications();

}