Support per property CSS Animation stacks

Source/core/animation/AnimationStack.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/animation/AnimationStack.h"
 
 #include "core/animation/CompositorAnimations.h"
-#include "core/animation/StyleInterpolation.h"
+#include "core/animation/InvalidatableStyleInterpolation.h"
 #include "core/animation/css/CSSAnimations.h"
+#include "platform/RuntimeEnabledFeatures.h"
 #include "wtf/BitArray.h"
 #include "wtf/NonCopyingSort.h"
 #include <algorithm>
 
 namespace blink {
 
 namespace {
 
-void copyToActiveInterpolationMap(const Vector<RefPtr<Interpolation>>& source, ActiveInterpolationMap& target)
+void copyToActiveInterpolationMap(const Vector<RefPtr<Interpolation>>& source, ActiveInterpolationsMap& target)

[dstockwell, 2015/09/07 03:11:36]

copyToActiveInterpolation*s*Map?

[alancutter (OOO until 2018), 2015/09/07 03:36:46]

Done.

 {
     for (const auto& interpolation : source) {
-        target.set(interpolation->property(), interpolation.get());
+        ActiveInterpolationsMap::iterator entry = target.find(interpolation->property());
+        if (entry == target.end()) {
+            // Python version of this line: target[interpolation.property] = [interpolation]
+            target.set(interpolation->property(), ActiveInterpolations(1)).storedValue->value.at(0) = interpolation.get();

[dstockwell, 2015/09/07 03:11:36]

is there a way to avoid the second hash here?

[alancutter (OOO until 2018), 2015/09/07 03:36:46]

Done.

+        } else if (RuntimeEnabledFeatures::stackedCSSPropertyAnimationsEnabled()
+            && interpolation->isInvalidatableStyleInterpolation()
+            && toInvalidatableStyleInterpolation(*interpolation).dependsOnUnderlyingValue()) {

[dstockwell, 2015/09/07 03:11:36]

Why is dependonunderlying part of invalidatablestyleinterpolation -- I assume
this will apply to other interpolations too?

[alancutter (OOO until 2018), 2015/09/07 03:36:46]

Correct, InvalidatableStyleInterpolation will eventually be merged upstream into
Interpolation once the old code has been replaced completely.

+            entry->value.append(interpolation.get());
+        } else {
+            entry->value.at(0) = interpolation.get();
+        }
     }
 }
 
 bool compareEffects(const Member<SampledEffect>& effect1, const Member<SampledEffect>& effect2)
 {
     ASSERT(effect1 && effect2);
     return effect1->sequenceNumber() < effect2->sequenceNumber();
 }
 
-void copyNewAnimationsToActiveInterpolationMap(const HeapVector<Member<InertEffect>>& newAnimations, ActiveInterpolationMap& result)
+void copyNewAnimationsToActiveInterpolationMap(const HeapVector<Member<InertEffect>>& newAnimations, ActiveInterpolationsMap& result)
 {
     for (const auto& newAnimation : newAnimations) {
         OwnPtr<Vector<RefPtr<Interpolation>>> sample;
         newAnimation->sample(sample);
         if (sample)
             copyToActiveInterpolationMap(*sample, result);
     }
 }
 
 } // namespace
 
 AnimationStack::AnimationStack()
 {
 }
 
 bool AnimationStack::hasActiveAnimationsOnCompositor(CSSPropertyID property) const
 {
     for (const auto& sampledEffect : m_effects) {
         // TODO(dstockwell): move the playing check into AnimationEffect and expose both hasAnimations and hasActiveAnimations
         if (sampledEffect->effect() && sampledEffect->effect()->animation()->playing() && sampledEffect->effect()->hasActiveAnimationsOnCompositor(property))
             return true;
     }
     return false;
 }
 
-ActiveInterpolationMap AnimationStack::activeInterpolations(AnimationStack* animationStack, const HeapVector<Member<InertEffect>>* newAnimations, const HeapHashSet<Member<const Animation>>* suppressedAnimations, KeyframeEffect::Priority priority, double timelineCurrentTime)
+ActiveInterpolationsMap AnimationStack::activeInterpolations(AnimationStack* animationStack, const HeapVector<Member<InertEffect>>* newAnimations, const HeapHashSet<Member<const Animation>>* suppressedAnimations, KeyframeEffect::Priority priority, double timelineCurrentTime)
 {
     // We don't exactly know when new animations will start, but timelineCurrentTime is a good estimate.
 
-    ActiveInterpolationMap result;
+    ActiveInterpolationsMap result;
 
     if (animationStack) {
         HeapVector<Member<SampledEffect>>& effects = animationStack->m_effects;
         // std::sort doesn't work with OwnPtrs
         nonCopyingSort(effects.begin(), effects.end(), compareEffects);
         animationStack->removeClearedEffects();
         for (const auto& effect : effects) {
             if (effect->priority() != priority || (suppressedAnimations && effect->effect() && suppressedAnimations->contains(effect->effect()->animation())))
                 continue;
             copyToActiveInterpolationMap(effect->interpolations(), result);
@@ skipping 34 matching lines @@
             FloatBox expandingBox(originalBox);
             if (!CompositorAnimations::instance()->getAnimatedBoundingBox(expandingBox, *effect->model(), startRange, endRange))
                 return false;
             box.expandTo(expandingBox);
         }
     }
     return true;
 }
 
 } // namespace blink