Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7055)

Unified Diff: chrome/installer/mini_installer/BUILD.gn

Issue 1329833002: Improve mini installer and official build GN flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer/BUILD.gn
diff --git a/chrome/installer/mini_installer/BUILD.gn b/chrome/installer/mini_installer/BUILD.gn
index 54aaea0155ef44658071ad4d01d52a0b0a3726bf..1fe4df9e139f500d444f9f076944be9a62fd1671 100644
--- a/chrome/installer/mini_installer/BUILD.gn
+++ b/chrome/installer/mini_installer/BUILD.gn
@@ -5,6 +5,7 @@
import("//build/config/features.gni")
import("//build/config/ui.gni")
import("//build/module_args/v8.gni")
+import("//chrome/version.gni")
import("//third_party/icu/config.gni")
config("mini_installer_compiler_flags") {
@@ -12,6 +13,7 @@ config("mini_installer_compiler_flags") {
"/bigobj",
"/Gy", # Enable function-level linking.
"/GS-", # Disable buffer security checking.
+ "/FS", # Preserve previous PDB behavior.
scottmg 2015/09/03 21:22:25 This is duplicated from build/config/compiler so t
brettw 2015/09/04 16:53:15 I have no idea. I just copy the code from the GYP.
]
cflags_c = [ "/TC" ]
@@ -40,11 +42,19 @@ source_set("lib") {
"regkey.h",
]
+ configs -= [ "//build/config/compiler:compiler" ]
+ configs += [ ":mini_installer_compiler_flags" ]
+
deps = [
#"test_installer_sentinel", TODO(GYP) bug 521052.
]
}
+process_version("version") {
+ template_file = "mini_installer_exe_version.rc.version"
+ output = "$target_gen_dir/mini_installer_version.rc"
+}
+
source_set("unit_tests") {
testonly = true
@@ -155,7 +165,6 @@ action("archive") {
executable("mini_installer") {
sources = [
"mini_installer.cc",
- "mini_installer_exe_version.rc.version",
packed_files_rc_file,
]
@@ -182,8 +191,8 @@ executable("mini_installer") {
deps = [
":archive",
":lib",
+ ":version",
"//build/config/sanitizers:deps",
"//build/win:default_exe_manifest",
- "//chrome/installer/setup",
]
}
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698