Improve mini installer and official build GN flags

chrome/installer/mini_installer/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/module_args/v8.gni")
+import("//chrome/version.gni")
 import("//third_party/icu/config.gni")
 
 config("mini_installer_compiler_flags") {
   cflags = [
     "/bigobj",
     "/Gy",  # Enable function-level linking.
     "/GS-",  # Disable buffer security checking.
+    "/FS",  # Preserve previous PDB behavior.

[scottmg, 2015/09/03 21:22:25]

This is duplicated from build/config/compiler so that it's /GS- rather than /GS?
Is that really necessary?

[brettw, 2015/09/04 16:53:15]

I have no idea. I just copy the code from the GYP.

   ]
 
   cflags_c = [ "/TC" ]
   cflags_cc = [ "/TP" ]
 }
 
 source_set("lib") {
   sources = [
     "appid.h",
     "chrome.release",
     "chrome_appid.cc",
     "configuration.cc",
     "configuration.h",
     "decompress.cc",
     "decompress.h",
     "mini_installer.ico",
     "mini_installer.rc",
     "mini_installer_constants.cc",
     "mini_installer_constants.h",
     "mini_installer_resource.h",
     "mini_string.cc",
     "mini_string.h",
     "pe_resource.cc",
     "pe_resource.h",
     "regkey.cc",
     "regkey.h",
   ]
 
+  configs -= [ "//build/config/compiler:compiler" ]
+  configs += [ ":mini_installer_compiler_flags" ]
+
   deps = [
     #"test_installer_sentinel",  TODO(GYP) bug 521052.
   ]
 }
 
+process_version("version") {
+  template_file = "mini_installer_exe_version.rc.version"
+  output = "$target_gen_dir/mini_installer_version.rc"
+}
+
 source_set("unit_tests") {
   testonly = true
 
   sources = [
     "configuration_test.cc",
     "decompress_test.cc",
     "mini_string_test.cc",
   ]
 
   public_deps = [
@@ skipping 90 matching lines @@
 
     #"../chrome.gyp:chrome_nacl_win64",  TODO(GYP) bug 512869.
   ]
 }
 
 # TODO(GYP) bug 521052: This target needs to be checked to make sure its the
 # same size as the GYP build.
 executable("mini_installer") {
   sources = [
     "mini_installer.cc",
-    "mini_installer_exe_version.rc.version",
     packed_files_rc_file,
   ]
 
   # This target is special so we manually override most linker flags and
   # specify our own to keep the size down.
   configs -= [
     "//build/config/compiler:compiler",
     "//build/config/win:common_linker_setup",
     "//build/config/win:console",
   ]
   configs += [
     ":mini_installer_compiler_flags",
     "//build/config/win:windowed",
   ]
 
   ldflags = [
     "/ENTRY:MainEntryPoint",
     "/FIXED:NO",
     "/NXCOMPAT",
   ]
 
   libs = [ "setupapi.lib" ]
 
   deps = [
     ":archive",
     ":lib",
+    ":version",
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
-    "//chrome/installer/setup",
   ]
 }