Move from UnusedSlotXX to REMOVEDOldFeature in UseCounter.h

Move from UnusedSlotXX to REMOVEDOldFeature in UseCounter.h

The previous system would end up with either out-of-order slots, which
makes it hard to find the next free slot, or would require frequent
re-ordering, which makes patches harder to write and review.

Some digging was done to find the original names for each slot.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165277

[philipj_slow, 2014-01-16 17:40:21]

Couldn't sleep :)

[eseidel, 2014-01-16 17:42:24]

lgtm

Works for me.

[commit-bot: I haz the power, 2014-01-16 17:42:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/132983005/1

[commit-bot: I haz the power, 2014-01-16 17:42:39]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #5 FAILED at 132.
  1 out of 9 hunks FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
31d00e4a8a8500e89d8012fd16c3ee1a857a71fa..00e88d669892d2c5c59edddfdc1dc6f0162b4105
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -70,7 +70,7 @@ public:
         PrefixedContentSecurityPolicy,
         UnprefixedIndexedDB,
         OpenWebDatabase,
-        UnusedSlot01, // Prior to 7/2013, we used this slot for
LegacyHTMLNotifications.
+        REMOVEDLegacyHTMLNotifications,
         LegacyTextNotifications,
         UnprefixedRequestAnimationFrame,
         PrefixedRequestAnimationFrame,
@@ -81,7 +81,7 @@ public:
         UnprefixedTransitionEndEvent,
         PrefixedAndUnprefixedTransitionEndEvent,
         AutoFocusAttribute,
-        UnusedSlot02, // Prior to 4/2013, we used this slot for
AutoSaveAttribute.
+        REMOVEDAutoSaveAttribute,
         DataListElement,
         FormAttribute,
         IncrementalAttribute,
@@ -113,9 +113,9 @@ public:
         StepAttribute,
         PageVisits,
         HTMLMarqueeElement,
-        UnusedSlot03, // Removed, was tracking overflow: -webkit-marquee.
+        REMOVEDCSSOverflowMarquee,
         Reflection,
-        CursorVisibility, // Removed, was -webkit-cursor-visibility.
+        REMOVEDCursorVisibility,
         StorageInfo,
         XFrameOptions,
         XFrameOptionsSameOrigin,
@@ -123,7 +123,7 @@ public:
         DeprecatedFlexboxWebContent,
         DeprecatedFlexboxChrome,
         DeprecatedFlexboxChromeExtension,
-        UnusedSlot04,
+        REMOVEDSVGTRefElement,
         UnprefixedPerformanceTimeline,
         PrefixedPerformanceTimeline,
         UnprefixedUserTiming,
@@ -132,7 +132,7 @@ public:
         ContentSecurityPolicyWithBaseElement,
         PrefixedMediaAddKey,
         PrefixedMediaGenerateKeyRequest,
-        UnusedSlot10, // Removed, was AudioBufferSourceNode.looping.
+        REMOVEDWebAudioLooping,
         DocumentClear,
         PrefixedTransitionMediaFeature,
         SVGFontElement,
@@ -140,7 +140,7 @@ public:
         XSLProcessingInstruction,
         XSLTProcessor,
         SVGSwitchElement,
-        UnusedSlot05, // Removed, was document.webkitRegister
+        REMOVEDPrefixedDocumentRegister,
         HTMLShadowElementOlderShadowRoot,
         DocumentAll,
         FormElement,
@@ -180,7 +180,7 @@ public:
         NodeIsSameNode, // Removed from DOM4.
         NodeIsSupported, // Removed from DOM4.
         NodeNamespaceURI, // Removed from DOM4.
-        UnusedSlot06, // Removed, was Node.prefix.
+        REMOVEDNodePrefix,
         NodeLocalName, // Removed from DOM4.
         NavigatorProductSub,
         NavigatorVendor,
@@ -217,9 +217,9 @@ public:
         SVGFontInCSS,
         ScrollTopBodyNotQuirksMode,
         ScrollLeftBodyNotQuirksMode,
-        UnusedSlot07, // Removed, was Attr.isId.
-        UnusedSlot08, // Removed, was Attr.ownerElement.
-        UnusedSlot09, // Removed, was Attr.prefix setter.
+        REMOVEDAttributeIsId,
+        REMOVEDAttributeOwnerElement,
+        REMOVEDAttributeSetPrefix,
         AttributeSpecified, // Removed in DOM4.
         BeforeLoadEventInIsolatedWorld,
         PrefixedAudioDecodedByteCount,
@@ -286,7 +286,7 @@ public:
         CSSStyleDeclarationGetPropertyCSSValue,
         SVGElementGetPresentationAttribute,
         // Add new features immediately above this line. Don't change assigned
-        // numbers of each items, and don't reuse unused slots.
+        // numbers of any item, and don't reuse removed slots.
         NumberOfFeatures, // This enum value must be last.
     };

[philipj_slow, 2014-01-16 17:44:15]

Depends on https://codereview.chromium.org/140973002/ :)

[commit-bot: I haz the power, 2014-01-17 03:13:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/132983005/90001

[commit-bot: I haz the power, 2014-01-17 04:01:33]

Retried try job too often on linux_blink_rel for step(s) webkit_tests,
webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-17 04:28:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/132983005/90001

[commit-bot: I haz the power, 2014-01-17 04:55:39]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-17 06:07:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/132983005/90001

[commit-bot: I haz the power, 2014-01-17 07:02:50]

Change committed as 165277