Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 132983002: Replace OutputSnapshot |is_internal| with check against 'type == OUTPUT_TYPE_INTERNAL' (Closed)

Created:
6 years, 11 months ago by dnicoara
Modified:
6 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Replace OutputSnapshot |is_internal| with check against 'type == OUTPUT_TYPE_INTERNAL' BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244311

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M ash/display/display_change_observer_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/display/output_configurator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/display/output_configurator.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M chromeos/display/output_configurator_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/display/real_output_configurator_delegate.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dnicoara
PTAL
6 years, 11 months ago (2014-01-10 16:05:41 UTC) #1
oshima
lgtm Can you update the BUG line like this? BUG=None
6 years, 11 months ago (2014-01-10 17:18:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/132983002/30001
6 years, 11 months ago (2014-01-10 17:40:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/132983002/30001
6 years, 11 months ago (2014-01-10 23:40:38 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 02:26:08 UTC) #5
Message was sent while issue was closed.
Change committed as 244311

Powered by Google App Engine
This is Rietveld 408576698