Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1329823002: Remove a public access specifier (Closed)

Created:
5 years, 3 months ago by Savago
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove a public access specifier BUG= Committed: https://crrev.com/0b5c39384f4485216ded053d1de43884b0153023 git-svn-id: svn://svn.chromium.org/blink/trunk@201989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Addressing reviewer's comments. #

Patch Set 3 : Remove a single unneeded access specifier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/layout/LayoutObject.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (2 generated)
Savago
5 years, 3 months ago (2015-09-03 17:07:12 UTC) #2
pdr.
I think these functions were located where they are to keep the tree manipulation code ...
5 years, 3 months ago (2015-09-03 19:26:22 UTC) #3
Savago
pdr I agree, please see updated patch were the manipulation functions are grouped together.
5 years, 3 months ago (2015-09-04 17:30:10 UTC) #4
pdr.
On 2015/09/04 at 17:30:10, a.cavalcanti wrote: > pdr > > I agree, please see updated ...
5 years, 3 months ago (2015-09-08 22:12:38 UTC) #5
Savago
Coolio, we can at least remove an access specifier keeping the code as it is.
5 years, 3 months ago (2015-09-09 17:56:28 UTC) #6
pdr.
lgtm
5 years, 3 months ago (2015-09-09 17:58:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329823002/40001
5 years, 3 months ago (2015-09-09 17:58:55 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201989
5 years, 3 months ago (2015-09-09 18:45:52 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:01:33 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0b5c39384f4485216ded053d1de43884b0153023

Powered by Google App Engine
This is Rietveld 408576698