Crankshaft: consolidated element loads always deopted on seeing the hole

Crankshaft: consolidated element loads always deopted on seeing the hole

Update the consolidated load case to carefully chose the load mode
based on the consolidated elements kind.

BUG=v8:4380
LOG=N

Committed: https://crrev.com/164f92d206c6dc203c485a5c154e4aafa0c46c95
Cr-Commit-Position: refs/heads/master@{#30659}

[mvstanton, 2015-09-08 15:38:50]

mvstanton@chromium.org changed reviewers:
+ jkummerow@chromium.org

[mvstanton, 2015-09-08 15:38:51]

Hi Jakob,
Here is the fix we were talking about, thx for the look!
--Michael

[Jakob Kummerow, 2015-09-09 14:12:18]

lgtm

https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc#newcode...
src/hydrogen.cc:7447: if (*map !=
isolate()->get_initial_js_array_map(map->elements_kind())) {
Isn't this condition...

https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc#newcode...
src/hydrogen.cc:7448: if (map->prototype() !=
*isolate()->initial_array_prototype()) {
...implied by this one? Seems like you could simply drop the first check. (And
update the comment accordingly.)

[mvstanton, 2015-09-09 14:41:30]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-09-09 14:41:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1329793003/#ps40001
(title: "Code comments.")

[commit-bot: I haz the power, 2015-09-09 14:41:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329793003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329793003/40001

[mvstanton, 2015-09-09 14:41:56]

Right on, thanks for the help thinking through it too.

https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc#newcode...
src/hydrogen.cc:7447: if (*map !=
isolate()->get_initial_js_array_map(map->elements_kind())) {
On 2015/09/09 14:12:18, Jakob wrote:
> Isn't this condition...

Acknowledged.

https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc#newcode...
src/hydrogen.cc:7448: if (map->prototype() !=
*isolate()->initial_array_prototype()) {
On 2015/09/09 14:12:18, Jakob wrote:
> ...implied by this one? Seems like you could simply drop the first check. (And
> update the comment accordingly.)

Oh yeah, thanks! :)

[commit-bot: I haz the power, 2015-09-09 15:15:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-09 15:15:38]

Patchset 3 (id:??) landed as
https://crrev.com/164f92d206c6dc203c485a5c154e4aafa0c46c95
Cr-Commit-Position: refs/heads/master@{#30659}