Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: pkg/analyzer/test/generated/all_the_rest_test.dart

Issue 1329743005: Abstract over the type system. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/strong_mode.dart ('k') | pkg/analyzer/test/generated/engine_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/all_the_rest_test.dart
diff --git a/pkg/analyzer/test/generated/all_the_rest_test.dart b/pkg/analyzer/test/generated/all_the_rest_test.dart
index 9765af9ee937d9d5246ea0e3cc703c3b421ecc5e..bc1fc52a37f1f390bc6178b84620459c2280a10f 100644
--- a/pkg/analyzer/test/generated/all_the_rest_test.dart
+++ b/pkg/analyzer/test/generated/all_the_rest_test.dart
@@ -868,8 +868,8 @@ class ConstantEvaluatorTest extends ResolverTestCase {
NodeList<VariableDeclaration> variables =
(declaration as TopLevelVariableDeclaration).variables.variables;
expect(variables, hasLength(1));
- ConstantEvaluator evaluator =
- new ConstantEvaluator(source, analysisContext.typeProvider);
+ ConstantEvaluator evaluator = new ConstantEvaluator(
+ source, analysisContext.typeProvider, analysisContext.typeSystem);
return evaluator.evaluate(variables[0].initializer);
}
}
@@ -2361,6 +2361,7 @@ class A {
validator.computer = new ConstantValueComputer(
analysisContext2,
analysisContext2.typeProvider,
+ analysisContext2.typeSystem,
analysisContext2.declaredVariables,
validator);
return validator.computer;
@@ -2393,8 +2394,8 @@ class ConstantVisitorTest extends ResolverTestCase {
_assertValue(
0,
expression.accept(new ConstantVisitor(
- new ConstantEvaluationEngine(
- new TestTypeProvider(), new DeclaredVariables()),
+ new ConstantEvaluationEngine(new TestTypeProvider(),
+ new TypeSystemImpl(), new DeclaredVariables()),
errorReporter)));
errorListener.assertNoErrors();
}
@@ -2409,8 +2410,8 @@ class ConstantVisitorTest extends ResolverTestCase {
ErrorReporter errorReporter =
new ErrorReporter(errorListener, _dummySource());
DartObjectImpl result = expression.accept(new ConstantVisitor(
- new ConstantEvaluationEngine(
- new TestTypeProvider(), new DeclaredVariables()),
+ new ConstantEvaluationEngine(new TestTypeProvider(),
+ new TypeSystemImpl(), new DeclaredVariables()),
errorReporter));
expect(result, isNull);
errorListener
@@ -2426,8 +2427,8 @@ class ConstantVisitorTest extends ResolverTestCase {
ErrorReporter errorReporter =
new ErrorReporter(errorListener, _dummySource());
DartObjectImpl result = expression.accept(new ConstantVisitor(
- new ConstantEvaluationEngine(
- new TestTypeProvider(), new DeclaredVariables()),
+ new ConstantEvaluationEngine(new TestTypeProvider(),
+ new TypeSystemImpl(), new DeclaredVariables()),
errorReporter));
expect(result, isNull);
errorListener
@@ -2443,8 +2444,8 @@ class ConstantVisitorTest extends ResolverTestCase {
ErrorReporter errorReporter =
new ErrorReporter(errorListener, _dummySource());
DartObjectImpl result = expression.accept(new ConstantVisitor(
- new ConstantEvaluationEngine(
- new TestTypeProvider(), new DeclaredVariables()),
+ new ConstantEvaluationEngine(new TestTypeProvider(),
+ new TypeSystemImpl(), new DeclaredVariables()),
errorReporter));
expect(result, isNull);
errorListener
@@ -2462,8 +2463,8 @@ class ConstantVisitorTest extends ResolverTestCase {
_assertValue(
1,
expression.accept(new ConstantVisitor(
- new ConstantEvaluationEngine(
- new TestTypeProvider(), new DeclaredVariables()),
+ new ConstantEvaluationEngine(new TestTypeProvider(),
+ new TypeSystemImpl(), new DeclaredVariables()),
errorReporter)));
errorListener.assertNoErrors();
}
@@ -2536,7 +2537,8 @@ const b = 3;''');
GatheringErrorListener errorListener = new GatheringErrorListener();
ErrorReporter errorReporter = new ErrorReporter(errorListener, source);
DartObjectImpl result = expression.accept(new ConstantVisitor(
- new ConstantEvaluationEngine(typeProvider, new DeclaredVariables()),
+ new ConstantEvaluationEngine(
+ typeProvider, typeSystem, new DeclaredVariables()),
errorReporter,
lexicalEnvironment: lexicalEnvironment));
errorListener.assertNoErrors();
« no previous file with comments | « pkg/analyzer/lib/src/task/strong_mode.dart ('k') | pkg/analyzer/test/generated/engine_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698