Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1329713002: Add convenience methods for checking horizontal size class. (Closed)

Created:
5 years, 3 months ago by lpromero
Modified:
5 years, 3 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add convenience methods for checking horizontal size class. This CL adds methods to check for horizontal size class of views, view controllers, etc. BUG=527404 R=justincohen@chromium.org,rohitrao@chromium.org Committed: https://crrev.com/ab739017d7ca888b9aba780b2f90afe318153c53 Cr-Commit-Position: refs/heads/master@{#347211}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M ios/chrome/browser/ui/uikit_ui_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util.mm View 1 2 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
lpromero
5 years, 3 months ago (2015-09-02 13:20:26 UTC) #1
justincohen
lgtm
5 years, 3 months ago (2015-09-02 15:11:16 UTC) #2
lpromero
Ping Rohit
5 years, 3 months ago (2015-09-02 17:28:24 UTC) #3
lpromero
+pkl for OWNERS in Rohit's absence
5 years, 3 months ago (2015-09-03 13:46:20 UTC) #5
Eugene But (OOO till 7-30)
lgtm
5 years, 3 months ago (2015-09-03 18:49:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329713002/40001
5 years, 3 months ago (2015-09-03 18:51:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/96261)
5 years, 3 months ago (2015-09-03 19:03:52 UTC) #12
pkl (ping after 24h if needed)
lgtm
5 years, 3 months ago (2015-09-03 19:15:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329713002/40001
5 years, 3 months ago (2015-09-03 19:16:45 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-03 19:22:40 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 19:23:34 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab739017d7ca888b9aba780b2f90afe318153c53
Cr-Commit-Position: refs/heads/master@{#347211}

Powered by Google App Engine
This is Rietveld 408576698