Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1329703004: Revert of Pass the v8::Context through the willDestroyServiceWorkerContextOnWorkerThread event. (Closed)

Created:
5 years, 3 months ago by kalman_google
Modified:
4 years, 11 months ago
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, tzik, extensions-reviews_chromium.org, serviceworker-reviews, jam, jsbell+serviceworker_chromium.org, nhiroki, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass the v8::Context through the willDestroyServiceWorkerContextOnWorkerThread event. (patchset #3 id:60001 of https://codereview.chromium.org/1318643002/ ) Reason for revert: Appears to be crashing on Canary. Original issue's description: > Pass the v8::Context through the willDestroyServiceWorkerContextOnWorkerThread event. > > Currently it only passes a URL, and this isn't enough to uniquely identify the worker. > Update extension's dispatcher.cc to use the context. > > BUG=501569, 525965 > R=kinuko@chromium.org, thestig@chromium.org > > Committed: https://crrev.com/4a0bb926cb1d83fab27b6ad866c04ba481f66268 > Cr-Commit-Position: refs/heads/master@{#346424} TBR=thestig@chromium.org,kinuko@chromium.org,kalman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501569, 525965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -77 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M extensions/renderer/dispatcher.h View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 3 chunks +15 lines, -56 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kalman_google
Created Revert of Pass the v8::Context through the willDestroyServiceWorkerContextOnWorkerThread event.
5 years, 3 months ago (2015-09-02 16:16:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329703004/1
5 years, 3 months ago (2015-09-02 16:16:53 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-02 16:16:55 UTC) #4
not at google - send to devlin
On 2015/09/02 16:16:55, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 3 months ago (2015-09-02 18:35:17 UTC) #5
Lei Zhang
On 2015/09/02 18:35:17, kalman wrote: > On 2015/09/02 16:16:55, commit-bot: I haz the power wrote: ...
5 years, 3 months ago (2015-09-02 18:44:35 UTC) #6
not at google - send to devlin
5 years, 3 months ago (2015-09-02 19:00:04 UTC) #7
On 2015/09/02 18:44:35, Lei Zhang wrote:
> On 2015/09/02 18:35:17, kalman wrote:
> > On 2015/09/02 16:16:55, commit-bot: I haz the power wrote:
> > > No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
> > > Even if an L-G-T-M may have been provided, it was from a non-committer,
> > > _not_ a full super star committer.
> > > See http://www.chromium.org/getting-involved/become-a-committer
> > > Note that this has nothing to do with OWNERS files.
> > 
> > damn.
> 
> You'd think all the NOFOO=true and TBR would have done something.

I was somehow logged in as my google.com account.

Powered by Google App Engine
This is Rietveld 408576698