Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 13297004: extend FontConfigInterface to start to match new fontmgr design (Closed)

Created:
7 years, 8 months ago by reed1
Modified:
7 years, 8 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

extend FontConfigInterface to start to match new fontmgr design Committed: https://code.google.com/p/skia/source/detail?r=8575

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M trunk/include/ports/SkFontConfigInterface.h View 1 2 3 4 5 3 chunks +10 lines, -0 lines 0 comments Download
M trunk/src/ports/SkFontConfigInterface_direct.cpp View 1 2 3 4 5 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
trying to design this with chrome's IPC needs in mind
7 years, 8 months ago (2013-03-29 18:55:07 UTC) #1
bungeman-skia
https://codereview.chromium.org/13297004/diff/1004/trunk/include/ports/SkFontConfigInterface.h File trunk/include/ports/SkFontConfigInterface.h (right): https://codereview.chromium.org/13297004/diff/1004/trunk/include/ports/SkFontConfigInterface.h#newcode87 trunk/include/ports/SkFontConfigInterface.h:87: struct Style { Should the style also contain a ...
7 years, 8 months ago (2013-03-29 19:40:36 UTC) #2
reed1
https://codereview.chromium.org/13297004/diff/1004/trunk/include/ports/SkFontConfigInterface.h File trunk/include/ports/SkFontConfigInterface.h (right): https://codereview.chromium.org/13297004/diff/1004/trunk/include/ports/SkFontConfigInterface.h#newcode87 trunk/include/ports/SkFontConfigInterface.h:87: struct Style { On 2013/03/29 19:40:36, bungeman1 wrote: > ...
7 years, 8 months ago (2013-03-29 20:11:58 UTC) #3
reed1
now with bigger, fatter, identities
7 years, 8 months ago (2013-03-29 20:26:29 UTC) #4
bungeman-skia
I like this (PS5) the best so far, with the following musing. https://codereview.chromium.org/13297004/diff/9001/trunk/include/ports/SkFontConfigInterface.h File trunk/include/ports/SkFontConfigInterface.h ...
7 years, 8 months ago (2013-03-29 21:13:37 UTC) #5
reed1
7 years, 8 months ago (2013-04-09 15:54:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 manually as r8575 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698