Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1329653004: Revert of Automatically download gold plugin for cfi builds. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, pcc1
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Automatically download gold plugin for cfi builds. (patchset #1 id:1 of https://codereview.chromium.org/1303183005/ ) Reason for revert: Breaks windows. Original issue's description: > Automatically download gold plugin for cfi builds. > > BUG=chromium:515782 > LOG=n > NOTRY=true > > Committed: https://crrev.com/c8dbd2c477c47a34593a0e7deee55915425b4ac2 > Cr-Commit-Position: refs/heads/master@{#30556} TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:515782 Committed: https://crrev.com/1ec920704e4de56f652490bceebdc03b41efa5d2 Cr-Commit-Position: refs/heads/master@{#30558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
M build/download_gold_plugin.py View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Automatically download gold plugin for cfi builds.
5 years, 3 months ago (2015-09-03 12:50:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329653004/1
5 years, 3 months ago (2015-09-03 12:50:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 12:50:36 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 12:50:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ec920704e4de56f652490bceebdc03b41efa5d2
Cr-Commit-Position: refs/heads/master@{#30558}

Powered by Google App Engine
This is Rietveld 408576698