Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1329653003: [bindings] Club related constants for a runtime enabled flag in a single |if| block (Closed)

Created:
5 years, 3 months ago by vivekg_samsung
Modified:
5 years, 3 months ago
Reviewers:
haraken, vivekg
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Club related constants for a runtime enabled flag in a single |if| block For the same runtime enabled flag, the constant configuration installation should be moved into a single |if| block instead of multiple blocks. This patch also reduces the size of .text segment of libmodules.so by ~4k (component build on linux 64bit) R=haraken BUG=469961 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201710

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -17 lines) Patch
M Source/bindings/scripts/v8_interface.py View 2 chunks +7 lines, -4 lines 0 comments Download
M Source/bindings/templates/constants.cpp View 1 1 chunk +7 lines, -4 lines 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 1 chunk +5 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/core/TestPartialInterface.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vivekg
PTAL, thanks. Here is a diff of a small snippet of the generated code for ...
5 years, 3 months ago (2015-09-03 06:48:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329653003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329653003/20001
5 years, 3 months ago (2015-09-03 06:49:49 UTC) #4
vivekg
This patch also reduces the size of .text segment of libmodules.so by ~4k (before and ...
5 years, 3 months ago (2015-09-03 07:03:27 UTC) #6
haraken
LGTM
5 years, 3 months ago (2015-09-03 07:22:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329653003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329653003/20001
5 years, 3 months ago (2015-09-03 07:33:51 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 08:06:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201710

Powered by Google App Engine
This is Rietveld 408576698