Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1329643002: Fix type errors in unit test utilities. (Closed)

Created:
5 years, 3 months ago by pcc1
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, pcc
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix type errors in unit test utilities. Fixes all bad casts associated with operands of call and select operators in the test suite. Cleanup for cfi_vptr=1; see https://www.chromium.org/developers/testing/control-flow-integrity BUG=chromium:457523 R=bmeurer@chromium.org LOG=N Committed: https://crrev.com/e70f23f9591998a803883de58d4b27311924624b Cr-Commit-Position: refs/heads/master@{#30531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M test/unittests/compiler/node-test-utils.h View 3 chunks +6 lines, -6 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 10 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
pcc1
5 years, 3 months ago (2015-09-02 03:11:34 UTC) #1
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-02 04:04:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329643002/1
5 years, 3 months ago (2015-09-02 04:30:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 04:55:14 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 04:55:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e70f23f9591998a803883de58d4b27311924624b
Cr-Commit-Position: refs/heads/master@{#30531}

Powered by Google App Engine
This is Rietveld 408576698