Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1329583004: CPDFSDK_MediaActionHandler is unused. (Closed)

Created:
5 years, 3 months ago by Tom Sepez
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

CPDFSDK_MediaActionHandler is unused. It's never instantiated, and any pointers to it are always NULL. Also kill an unused arg to CPDFSDK_ActionHandler ctor along the way. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/23213b2750e33dfe96b091b78ec8b10fe4d73a67

Patch Set 1 #

Patch Set 2 : Remove unneeded class decls. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -57 lines) Patch
M fpdfsdk/include/fsdk_actionhandler.h View 1 3 chunks +1 line, -16 lines 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 4 chunks +2 lines, -40 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, dead code du jour.
5 years, 3 months ago (2015-09-01 20:49:05 UTC) #2
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-01 20:52:45 UTC) #3
Tom Sepez
5 years, 3 months ago (2015-09-01 20:53:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
23213b2750e33dfe96b091b78ec8b10fe4d73a67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698