Issue 1329583004: CPDFSDK_MediaActionHandler is unused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1329583004: CPDFSDK_MediaActionHandler is unused. (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

CPDFSDK_MediaActionHandler is unused. It's never instantiated, and any pointers to it are always NULL. Also kill an unused arg to CPDFSDK_ActionHandler ctor along the way. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/23213b2750e33dfe96b091b78ec8b10fe4d73a67

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -57 lines)			Patch
M	fpdfsdk/include/fsdk_actionhandler.h	View	1	3 chunks	+1 line, -16 lines	0 comments	Download
M	fpdfsdk/src/fsdk_actionhandler.cpp	View		4 chunks	+2 lines, -40 lines	0 comments	Download
M	fpdfsdk/src/fsdk_mgr.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 3 months ago (2015-09-01 20:53:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
23213b2750e33dfe96b091b78ec8b10fe4d73a67 (presubmit successful).