Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1329583002: Add missing Android GN build dep on md5sum. (Closed)

Created:
5 years, 3 months ago by scheib
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing Android GN build dep on md5sum. Clean builds of APK targets on Android fail to deploy without also building 'md5sum' target. Committed: https://crrev.com/ed031efc0a6c59a550e7ae0d9a7a109c4ebda3c6 Cr-Commit-Position: refs/heads/master@{#346720}

Patch Set 1 #

Total comments: 1

Patch Set 2 : data_deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/config/android/internal_rules.gni View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
scheib
5 years, 3 months ago (2015-09-01 19:13:23 UTC) #2
agrieve
+dpranke for owners https://codereview.chromium.org/1329583002/diff/1/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/1329583002/diff/1/build/config/android/internal_rules.gni#newcode788 build/config/android/internal_rules.gni:788: deps += [ "//tools/android/md5sum" ] # ...
5 years, 3 months ago (2015-09-01 19:29:40 UTC) #4
agrieve
On 2015/09/01 19:29:40, agrieve wrote: > +dpranke for owners > > https://codereview.chromium.org/1329583002/diff/1/build/config/android/internal_rules.gni > File build/config/android/internal_rules.gni ...
5 years, 3 months ago (2015-09-01 19:29:55 UTC) #5
scheib
> https://codereview.chromium.org/1329583002/diff/1/build/config/android/internal_rules.gni#newcode788 > build/config/android/internal_rules.gni:788: deps += [ "//tools/android/md5sum" > ] # Used when deploying APKs ...
5 years, 3 months ago (2015-09-01 19:37:07 UTC) #6
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-01 20:03:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329583002/20001
5 years, 3 months ago (2015-09-01 20:05:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 20:10:42 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 20:11:10 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed031efc0a6c59a550e7ae0d9a7a109c4ebda3c6
Cr-Commit-Position: refs/heads/master@{#346720}

Powered by Google App Engine
This is Rietveld 408576698