Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1329553002: Port enabling rtti for cfi. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, krasin1
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Port enabling rtti for cfi. Partially port https://codereview.chromium.org/1243373003/ BUG=chromium:515782 LOG=n NOTRY=true Committed: https://crrev.com/34ce987586bd74bd7d2f0c60d63420685b55c63e Cr-Commit-Position: refs/heads/master@{#30497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/standalone.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 3 months ago (2015-09-01 07:35:37 UTC) #2
Benedikt Meurer
LGTM.
5 years, 3 months ago (2015-09-01 07:49:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329553002/1
5 years, 3 months ago (2015-09-01 08:01:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 08:03:03 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 08:03:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34ce987586bd74bd7d2f0c60d63420685b55c63e
Cr-Commit-Position: refs/heads/master@{#30497}

Powered by Google App Engine
This is Rietveld 408576698