Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 132953003: android envsetup: Stop exporting STRIP. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

android envsetup: Stop exporting STRIP. After the changes in crbug.com/142642 , this should no longer be used. BUG=142642 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250109

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/android/envsetup_functions.sh View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
The red try run with the error about STRIP is from an old revision. I ...
6 years, 10 months ago (2014-02-10 04:00:53 UTC) #1
Torne
lgtm
6 years, 10 months ago (2014-02-10 12:02:21 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 10 months ago (2014-02-10 14:22:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/132953003/20001
6 years, 10 months ago (2014-02-10 14:22:23 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 16:04:43 UTC) #5
Message was sent while issue was closed.
Change committed as 250109

Powered by Google App Engine
This is Rietveld 408576698