Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1329523002: Revert of document.querySelector[All]() should check selector context (Closed)

Created:
5 years, 3 months ago by kochi
Modified:
5 years, 3 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, hayato, rwlbuis, sof
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert of document.querySelector[All]() should check selector context (patchset #6 id:100001 of https://codereview.chromium.org/1245933002/ ) Reason for revert: This seems to have caused a significant perf regression. Reverting. BUG=526742 Original issue's description: > document.querySelector[All]() should check selector context > > Blink failed to check whether the left-most matched selector ends up > in Document TreeScope. > The check was only enabled for querySelector*() is called on > a regular element, not on document. > > This issue can be exposed by passing "::shadow" or "/deep/" > which pierces shadow boundary and the selector can > incorrectly match inside shadow. > > BUG=511486 > TEST=fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201461 TBR=esprehn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=511486 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kochi
Created Revert of document.querySelector[All]() should check selector context
5 years, 3 months ago (2015-09-01 02:20:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329523002/1
5 years, 3 months ago (2015-09-01 02:20:21 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 02:20:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201514

Powered by Google App Engine
This is Rietveld 408576698