Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1329493004: [turbofan] Greedy: using hints (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Greedy: using hints This is a rudimentary introduction of hints. Primarily this helps with allocating on the same register variables are defined (from instructions) For dealing with phis, we need to introduce groups, in a subsequent CL. From the last CL (memory ops heuristics), this CL improves some benchmarks - notably Life (11.94%) in Emscripten x64, and Memops (Emscripten), 24% on x86; notable regressions: Memops in AreWeFastYet (-14%, x64) and Corrections -25% on x86. BUG= Committed: https://crrev.com/038f5eaf3bd6796ed6b7519de83c21d4e1f54850 Cr-Commit-Position: refs/heads/master@{#30534}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -26 lines) Patch
M src/compiler/greedy-allocator.cc View 4 chunks +35 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-02 06:43:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329493004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329493004/60001
5 years, 3 months ago (2015-09-02 06:43:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 3 months ago (2015-09-02 07:12:53 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/038f5eaf3bd6796ed6b7519de83c21d4e1f54850 Cr-Commit-Position: refs/heads/master@{#30534}
5 years, 3 months ago (2015-09-02 07:13:04 UTC) #8
Michael Hablich
5 years, 3 months ago (2015-09-02 08:34:48 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/1324763005/ by hablich@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20g....

Powered by Google App Engine
This is Rietveld 408576698