Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1329343004: Revert of [Android] Don't use a device blacklist if one isn't provided. (Closed)

Created:
5 years, 3 months ago by nednguyen
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Don't use a device blacklist if one isn't provided. (patchset #1 id:1 of https://codereview.chromium.org/1314823011/ ) Reason for revert: Suspect causing build failure (provision_devices step) BUG=530242 Original issue's description: > [Android] Don't use a device blacklist if one isn't provided. > > BUG=517709 > > Committed: https://crrev.com/be5c91849d2196f97c7a4e0b3e90597c3f2b4c40 > Cr-Commit-Position: refs/heads/master@{#347473} TBR=rnephew@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -37 lines) Patch
M build/android/adb_install_apk.py View 1 chunk +6 lines, -3 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/devil/android/device_blacklist.py View 2 chunks +22 lines, -5 lines 0 comments Download
M build/android/devil/android/device_utils.py View 1 chunk +5 lines, -1 line 0 comments Download
M build/android/enable_asserts.py View 1 chunk +4 lines, -3 lines 0 comments Download
M build/android/provision_devices.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/pylib/local/device/local_device_environment.py View 1 chunk +2 lines, -3 lines 0 comments Download
M build/android/screenshot.py View 1 chunk +4 lines, -3 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +7 lines, -4 lines 0 comments Download
M build/android/tombstones.py View 1 chunk +4 lines, -3 lines 0 comments Download
M build/android/update_verification.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nednguyen
Created Revert of [Android] Don't use a device blacklist if one isn't provided.
5 years, 3 months ago (2015-09-10 17:25:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329343004/1
5 years, 3 months ago (2015-09-10 17:25:39 UTC) #2
jbudorick
5 years, 3 months ago (2015-09-10 17:25:57 UTC) #4
On 2015/09/10 at 17:25:39, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1329343004/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1329343004/1

wrong CL.

Powered by Google App Engine
This is Rietveld 408576698