Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1329343002: Add a missing #include that's needed for call to FXSYS_tolower. (Closed)

Created:
5 years, 3 months ago by David Lattimore
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a missing #include that's needed for call to FXSYS_tolower. BUG= R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8ad46d3d6829d879cd342caec4c6f7eaae43cba0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M core/src/fxge/android/fpf_skiafontmgr.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
David Lattimore
5 years, 3 months ago (2015-09-10 03:30:52 UTC) #2
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-10 05:02:48 UTC) #3
Lei Zhang
Do you need to be added as a PDFium committer, so you can land this?
5 years, 3 months ago (2015-09-11 00:25:43 UTC) #4
David Lattimore
On 2015/09/11 00:25:43, Lei Zhang wrote: > Do you need to be added as a ...
5 years, 3 months ago (2015-09-11 00:32:38 UTC) #5
Lei Zhang
On 2015/09/11 00:32:38, David Lattimore wrote: > On 2015/09/11 00:25:43, Lei Zhang wrote: > > ...
5 years, 3 months ago (2015-09-11 01:24:51 UTC) #6
David Lattimore
5 years, 3 months ago (2015-09-14 21:40:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ad46d3d6829d879cd342caec4c6f7eaae43cba0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698